Fix utility function in smoke, add tests for it.

pkg/smoke/lib/src/common.dart

Index: pkg/smoke/lib/src/common.dart
diff --git a/pkg/smoke/lib/src/common.dart b/pkg/smoke/lib/src/common.dart
index 1d73e4ff836ceb04cd921ac62177cbc9305d8311..71a72f0badf004ca3548637eb6520994b8234035 100644
--- a/pkg/smoke/lib/src/common.dart
+++ b/pkg/smoke/lib/src/common.dart
@@ -84,10 +84,22 @@ bool compareLists(List a, List b, {bool unordered: false}) {
   if (a != null && b == null) return false;
   if (a.length != b.length) return false;
   if (unordered) {
-    var bSet = new Set()..addAll(b);
-    for (int i = 0; i < a.length; i++) {
-      if (!bSet.contains(a[i])) return false;
+    var countMap = {};
+    for (var x in b) {
+      var count = countMap[x];

[jakemac, 2014/07/23 20:13:44]

putIfAbsent?

[Siggi Cherem (dart-lang), 2014/07/23 20:30:58]

thanks for the suggestion - it could be

  countMap.putIfAbsent(x, () => 0);
  countMap[x]++;

I am honestly equally happy with either this or the one I currently have, so I
might just keep the one we have since it could be slightly cheaper.

+      if (count == null) count = 0;
+      countMap[x] = count + 1;
+    }
+    for (var x in a) {
+      var count = countMap[x];
+      if (count == null) return false;
+      if (count == 1) {
+        countMap.remove(x);
+      } else {
+        countMap[x] = count - 1;
+      }
     }
+    return countMap.isEmpty;
   } else {
     for (int i = 0; i < a.length; i++) {
       if (a[i] != b[i]) return false;