Fix utility function in smoke, add tests for it.

pkg/smoke/lib/src/common.dart

Index: pkg/smoke/lib/src/common.dart
diff --git a/pkg/smoke/lib/src/common.dart b/pkg/smoke/lib/src/common.dart
index 1d73e4ff836ceb04cd921ac62177cbc9305d8311..24ed4fd95ac38de14606ffdd82bdcc2504fb342d 100644
--- a/pkg/smoke/lib/src/common.dart
+++ b/pkg/smoke/lib/src/common.dart
@@ -88,6 +88,11 @@ bool compareLists(List a, List b, {bool unordered: false}) {
     for (int i = 0; i < a.length; i++) {
       if (!bSet.contains(a[i])) return false;
     }
+
+    var aSet = new Set()..addAll(a);
+    for (int i = 0; i < b.length; i++) {
+      if (!aSet.contains(b[i])) return false;
+    }

[vicb, 2014/07/13 09:55:02]

I think that the code is still not right.

[1 1 2 2 2] would still equal [1 1 1 2 2]

(As a side note it would be more efficient to compare Set vs Set rather than
compare Set vs List - we do build both aSet and bSet. However is is n/a as the
code seems to be incorrect)

[justinfagnani, 2014/07/14 17:20:19]

A Set is not going to work here, you need two maps of item->count. Calculate the
counts for each list, then compare the counts.

[Siggi Cherem (dart-lang), 2014/07/14 19:48:57]

<facepalm> ... Ok I updated this again, hopefully this is better now.

The reality is that this code is only used for the debug_static configuration,
which is just used while developing code generators to verify that a static
configuration contains everything you expect you'd get by comparing it with the
results from using mirrors (ignoring the order of some operations).

Most operations return lists, but in reality they are actually ordered-sets. So
these issues with duplicates were never a concern there. We could rename this as
compareListsContents and just use Set equality and we'd be good too.

   } else {
     for (int i = 0; i < a.length; i++) {
       if (a[i] != b[i]) return false;