Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: components/variations/proto/study.proto

Issue 370463003: Add support for variations controlled overriding UI strings to the variations service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: asvitkine's first round of comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/proto/study.proto
diff --git a/components/variations/proto/study.proto b/components/variations/proto/study.proto
index e58b8f9092aa78dc3f67347930048557cb9b6c52..18abcd5c7952e4f167eb74ba00676ffaa33a0276 100644
--- a/components/variations/proto/study.proto
+++ b/components/variations/proto/study.proto
@@ -43,7 +43,7 @@ message Study {
// An experiment within the study.
//
- // Next tag: 9
+ // Next tag: 10
message Experiment {
// A named parameter value for this experiment.
//
@@ -107,6 +107,16 @@ message Study {
KILL_CRITICAL = 3;
}
optional Type type = 7 [default = NORMAL];
+
+ // A UI string to override, and the new value to use. |name_hash| is the
+ // hash of the resource name to be overridden.
+ message OverrideUIString {
+ // The first 32 bits of the MD5 hash digest of the resource name to
+ // override.
+ optional fixed32 name_hash = 1; // e.g. Hash("IDS_BOOKMARK_BAR_UNDO")
Alexei Svitkine (slow) 2014/07/15 16:44:52 Nit: Move this line comment to be at the end of th
jwd 2014/07/16 21:33:05 Done.
+ optional string value = 2; // e.g. "Undo"
Alexei Svitkine (slow) 2014/07/15 16:44:52 Nit: Put comment above the field instead with a sh
jwd 2014/07/16 21:33:05 Done.
+ }
+ repeated OverrideUIString override_ui_string = 9;
}
// List of experiments in this study. This list should include the default /

Powered by Google App Engine
This is Rietveld 408576698