components/variations/proto/study.proto - Issue 370463003: Add support for variations controlled overriding UI strings to the variations service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/proto/study.proto

Issue 370463003: Add support for variations controlled overriding UI strings to the variations service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/variations/processed_study.cc ('K') | « components/variations/processed_study.cc ('k') | components/variations/variations_seed_processor.h » ('j') | components/variations/variations_seed_processor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/variations/proto/study.proto

diff --git a/components/variations/proto/study.proto b/components/variations/proto/study.proto

index e58b8f9092aa78dc3f67347930048557cb9b6c52..e2678b987ff60139b5d716e41764966d76bd6b14 100644

--- a/components/variations/proto/study.proto

+++ b/components/variations/proto/study.proto

@@ -43,7 +43,7 @@ message Study {

// An experiment within the study.

- // Next tag: 9

+ // Next tag: 10

message Experiment {

// A named parameter value for this experiment.

@@ -107,6 +107,12 @@ message Study {

KILL_CRITICAL = 3;

}

optional Type type = 7 [default = NORMAL];

+ message OverrideUIString {

+ optional fixed32 name_hash = 1; // e.g. Hash("IDS_BOOKMARK_BAR_FOLDER_NAME")

Alexei Svitkine (slow) 2014/07/03 17:54:40 Nit: Wrapping. But also, add some comments about t

jwd 2014/07/07 15:52:20 Done.

+ optional string value = 2; // e.g. "Bookmark Bar"

+ }

+ repeated OverrideUIString override_ui_string = 9;

}

// List of experiments in this study. This list should include the default /