chrome/browser/metrics/variations/generated_resources_map.h - Issue 370463003: Add support for variations controlled overriding UI strings to the variations service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/generated_resources_map.h

Issue 370463003: Add support for variations controlled overriding UI strings to the variations service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/variations/generate_resources_map.py ('k') | chrome/browser/metrics/variations/generated_resources_map_lookup.cc » ('j') | chrome/browser/metrics/variations/generated_resources_map_lookup.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/variations/generated_resources_map.h

diff --git a/chrome/browser/metrics/variations/generated_resources_map.h b/chrome/browser/metrics/variations/generated_resources_map.h

index 55b80a3eca8e1a49dc25e7014a101843c822cacc..fd857a143163e2faef8fc2404d2b951ff452423c 100644

--- a/chrome/browser/metrics/variations/generated_resources_map.h

+++ b/chrome/browser/metrics/variations/generated_resources_map.h

@@ -16,6 +16,8 @@ namespace chrome_variations {

// generated_resources.h contains |#define IDS_FOO 12345|, then for some index i

// kResourceHashes[i] = HASH("IDS_FOO") and kResourceIndices[i] = 12345.

+extern const size_t kNumResources;

Alexei Svitkine (slow) 2014/07/03 17:54:40 Add a comment. Also, probably move below the comme

jwd 2014/07/07 15:52:20 Done.

// The definitions of the arrays are generated by generate_resources_map.py from

// the content of generated_resources.h.

@@ -26,6 +28,8 @@ extern const uint32_t kResourceHashes[];

// to the order of |kResourceHashes|.

extern const int kResourceIndices[];

+int GetResourceIndex(uint32_t hash);

Alexei Svitkine (slow) 2014/07/03 17:54:40 Add a comment.

jwd 2014/07/07 15:52:19 Done.

} // namespace chrome_variations

#endif // CHROME_BROWSER_METRICS_VARIATIONS_GENERATED_RESOURCES_MAP_H_