Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1773)

Unified Diff: chrome/browser/metrics/variations/variations_service.cc

Issue 370463003: Add support for variations controlled overriding UI strings to the variations service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service.cc
diff --git a/chrome/browser/metrics/variations/variations_service.cc b/chrome/browser/metrics/variations/variations_service.cc
index 814125b23c5cf7b67433b58a32ddfcd181c2a2ab..998a93008a3881c02d72527c37c00e262657247c 100644
--- a/chrome/browser/metrics/variations/variations_service.cc
+++ b/chrome/browser/metrics/variations/variations_service.cc
@@ -17,6 +17,7 @@
#include "base/timer/elapsed_timer.h"
#include "base/version.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/metrics/variations/generated_resources_map.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "components/metrics/metrics_state_manager.h"
@@ -36,6 +37,7 @@
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request_status.h"
#include "ui/base/device_form_factor.h"
+#include "ui/base/resource/resource_bundle.h"
#include "url/gurl.h"
#if !defined(OS_ANDROID) && !defined(OS_IOS) && !defined(OS_CHROMEOS)
@@ -218,6 +220,17 @@ base::Time GetReferenceDateForExpiryChecks(PrefService* local_state) {
return reference_date;
}
+// Overrides the string resource sepecified by |hash| with |string| in the
+// resource bundle. Used as a callback passed to the variations seed processor.
+void OverrideUIString(uint32_t hash, const base::string16& string) {
+ int resource_id = GetResourceIndex(hash);
+ if (resource_id == -1)
+ return;
+
+ ui::ResourceBundle::GetSharedInstance().OverrideLocaleStringResource(
+ resource_id, string);
+}
+
} // namespace
VariationsService::VariationsService(
@@ -254,9 +267,14 @@ bool VariationsService::CreateTrialsFromSeed() {
return false;
VariationsSeedProcessor().CreateTrialsFromSeed(
- seed, g_browser_process->GetApplicationLocale(),
- GetReferenceDateForExpiryChecks(local_state_), current_version,
- GetChannelForVariations(), GetCurrentFormFactor(), GetHardwareClass());
+ seed,
+ g_browser_process->GetApplicationLocale(),
+ GetReferenceDateForExpiryChecks(local_state_),
+ current_version,
+ GetChannelForVariations(),
+ GetCurrentFormFactor(),
+ GetHardwareClass(),
+ base::Bind(&OverrideUIString));
// Log the "freshness" of the seed that was just used. The freshness is the
// time between the last successful seed download and now.
« no previous file with comments | « chrome/browser/metrics/variations/generated_resources_map_lookup_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698