Issue 370393002: Revert of Consolidated 'git' refish parsing into a class

Issue 370393002: Revert of Consolidated 'git' refish parsing into a class (Closed)

Created:
6 years, 5 months ago by smut

Modified:
6 years, 5 months ago

Reviewers:
Michael Moss, iannucci, M-A Ruel, nodir, dnj, agable

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Revert of Consolidated 'git' refish parsing into a class (https://codereview.chromium.org/328843005/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=391871 Original issue's description: > Consolidated 'git' refish parsing into a class > > Created the 'GitRefish' class to centralize 'git' refish parsing and consistent > usage by 'gclient' 'git' code. > > BUG=373504 > TEST=localtest > R=agable@chromium.org, iannucci@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281553 TBR=dnj BUG=391871 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281572

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -307 lines)			Patch
M	gclient.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gclient_scm.py	View	17 chunks	+36 lines, -166 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	3 chunks	+1 line, -139 lines	0 comments	Download
M	tests/gclient_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (0 generated)

smut

Created Revert of Consolidated 'git' refish parsing into a class

6 years, 5 months ago (2014-07-07 19:31:56 UTC) #1