Issue 370353004: Suppress new TSAN warnings from DMQuiltTask.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 370353004: Suppress new TSAN warnings from DMQuiltTask. (Closed)

Created:
6 years, 5 months ago by mtklein_C

Modified:
6 years, 5 months ago

Reviewers:
jcgregorio, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Suppress new TSAN warnings from DMQuiltTask. We're racing to invalidate the genID of our pixel ref when multiple threads write into it, and also to call its genID-changed listeners. We install no listeners on this particular pixel ref, nor do we ever care about its genID at all. So these are benign races, races on data we never make a decision from. BUG=skia:2725 Committed: https://skia.googlesource.com/skia/+/5e8a3c1b83b8e6f41452298a1da5343b471759fd

Patch Set 1 #

Patch Set 2 : bug #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/tsan.supp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/370353004/20001

6 years, 5 months ago (2014-07-07 19:59:27 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-07 20:11:33 UTC) #5

Message was sent while issue was closed.

Change committed as 5e8a3c1b83b8e6f41452298a1da5343b471759fd

Expand Messages | Collapse Messages