Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 370353003: Revert 169180 "Place inner frame scrollbars on the left side, if..." (Closed)

Created:
6 years, 5 months ago by tonikitoo_
Modified:
6 years, 5 months ago
Reviewers:
tonikitoo_
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert 169180 "Place inner frame scrollbars on the left side, if..." Patch cause layout problems as described in http://code.google.com/p/chromium/issues/detail?id=353111 > Place inner frame scrollbars on the left side, if indicated by the frame-level > text direction. > > CL overrides ScrollView::shouldPlaceVerticalScrollbarOnLeft() from FrameView in > order to determine if a Frame level scrollbar should be placed on the left. > Logic is simple: it obeys what ever is set to the body node, as it determines > the page text direction. > > For now, it only covers inner frames, as main frame level scrollbar placement > logic should be dictated by the application/system (see crbug.com/249860). > > Patch does not introduce new tests, but marks the existing affected tests as > NeedsManualRebaseline in order to get > results for all platforms from the bots, and perform rebaselines accordingly. > Once this is done, idea is to re-mark them as flaky. > > Bug=250514 > > Review URL: https://codereview.chromium.org/150733002 TBR=a1.gomes@sisa.samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -28 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +14 lines, -7 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tonikitoo_
6 years, 5 months ago (2014-07-07 18:48:06 UTC) #1
tonikitoo_
6 years, 5 months ago (2014-07-07 18:56:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r177601.

Powered by Google App Engine
This is Rietveld 408576698