Replace refcounting with weak pointers for BookmarkStore.

Replace refcounting with weak pointers for BookmarkStore.

This is the first step to de-flaking and re-enabling profile browser tests,
which are currently flaky due to an interaction with bookmarks.

Extracted from https://codereview.chromium.org/349263004/ to make that change more easily merge-able.

R=gab@chromium.org
TBR=brettw@chromium.org, sky@chromium.org 

BUG=141141, 141517, 142787, 140882, 165760, 163713
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281582

[Sigurður Ásgeirsson, 2014-07-07 15:23:27]

Hey Gab,

here are the BookmarkStore lifetime changes broken out as requested.
Brett: owners approval please?

Siggi

[gab, 2014-07-07 15:49:52]

lgtm, thanks!

(I assume you meant to add brettw as sky is OOO but seems that's not what you
did in the "reviewers" field)

Cheers,
Gab

[gab, 2014-07-07 15:58:06]

+brettw for OWNERS

[cpu1, 2014-07-07 18:45:09]

Please go ahead and land this TBR. I'll take the blame.

[Sigurður Ásgeirsson, 2014-07-07 18:48:43]

The CQ bit was checked by siggi@chromium.org

[commit-bot: I haz the power, 2014-07-07 18:50:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/siggi@chromium.org/370323002/1

[Sigurður Ásgeirsson, 2014-07-07 18:51:32]

Thanks, I'm getting into a bit of a time crunch with this ... CQ bit set.


On Mon, Jul 7, 2014 at 2:45 PM, <cpu@google.com> wrote:

> Please go ahead and land this TBR. I'll take the blame.
>
> https://codereview.chromium.org/370323002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-07-07 20:45:26]

Change committed as 281582