Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: content/browser/cocoa/system_hotkey_map_unittest.mm

Issue 370293004: mac: Load the system hotkeys after launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from rsesek by removing gcd. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/cocoa/system_hotkey_map_unittest.mm
diff --git a/chrome/browser/ui/cocoa/system_hotkey_map_unittest.mm b/content/browser/cocoa/system_hotkey_map_unittest.mm
similarity index 64%
rename from chrome/browser/ui/cocoa/system_hotkey_map_unittest.mm
rename to content/browser/cocoa/system_hotkey_map_unittest.mm
index dbcf01704843106ea3ea8b32372efb03ae2ca277..0ee23a4ca1dcab77175b5927e0fad41a4c78087b 100644
--- a/chrome/browser/ui/cocoa/system_hotkey_map_unittest.mm
+++ b/content/browser/cocoa/system_hotkey_map_unittest.mm
@@ -7,10 +7,12 @@
#import <Carbon/Carbon.h>
#import <Cocoa/Cocoa.h>
-#import "chrome/browser/ui/cocoa/system_hotkey_map.h"
-#include "chrome/test/base/ui_test_utils.h"
+#include "base/files/file_path.h"
+#include "base/path_service.h"
+#import "content/browser/cocoa/system_hotkey_map.h"
+#include "content/public/common/content_paths.h"
-namespace {
+namespace content {
class SystemHotkeyMapTest : public ::testing::Test {
public:
@@ -18,10 +20,14 @@ class SystemHotkeyMapTest : public ::testing::Test {
};
TEST_F(SystemHotkeyMapTest, Parse) {
- std::string path = ui_test_utils::GetTestUrl(
- base::FilePath(base::FilePath::kCurrentDirectory),
- base::FilePath("mac/mac_system_hotkeys.plist")).path();
- NSString* file_path = [NSString stringWithUTF8String:path.c_str()];
+ base::FilePath test_data_dir;
+ ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &test_data_dir));
+
+ base::FilePath test_path =
+ test_data_dir.AppendASCII("mac/mac_system_hotkeys.plist");
+ std::string test_path_string = test_path.AsUTF8Unsafe();
+ NSString* file_path =
+ [NSString stringWithUTF8String:test_path_string.c_str()];
NSData* data = [NSData dataWithContentsOfFile:file_path];
ASSERT_TRUE(data);
@@ -48,4 +54,12 @@ TEST_F(SystemHotkeyMapTest, Parse) {
EXPECT_FALSE(map.IsHotkeyReserved(key_code, modifiers));
}
-} // namespace
+TEST_F(SystemHotkeyMapTest, ParseNil) {
+ NSData* data = nil;
+
+ SystemHotkeyMap map;
+ bool result = map.ParseData(data);
+ EXPECT_FALSE(result);
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698