Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1818)

Unified Diff: chrome/browser/ui/browser.cc

Issue 370293004: mac: Load the system hotkeys after launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Histograms and dchecks. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index db19aee5d85607283b8c7f1bf17e173b15e94a7a..fc182f9671f0f66d97d44df88010140354750db0 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -209,6 +209,10 @@
#include "ash/ash_switches.h"
#endif
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+#include "chrome/browser/ui/cocoa/system_hotkey_helper_mac.h"
+#endif // defined(OS_MACOSX) && !defined(OS_IOS)
+
using base::TimeDelta;
using base::UserMetricsAction;
using content::NativeWebKeyboardEvent;
@@ -444,6 +448,11 @@ Browser::Browser(const CreateParams& params)
}
fullscreen_controller_.reset(new FullscreenController(this));
+
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+ // Load system hotkeys on OSX.
+ SystemHotkeyHelperMac::GetInstance()->DeferredLoadSystemHotkeys();
+#endif // defined(OS_MACOSX) && !defined(OS_IOS)
Avi (use Gerrit) 2014/07/07 21:57:49 But this isn't a per-Browser thing, this is a syst
erikchen 2014/07/08 01:51:39 I didn't realize that more than 1 Chrome browser i
Avi (use Gerrit) 2014/07/08 02:04:19 I don't have time for a full review right now (I'l
}
Browser::~Browser() {

Powered by Google App Engine
This is Rietveld 408576698