Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Side by Side Diff: content/browser/cocoa/system_hotkey_map.h

Issue 370293004: mac: Load the system hotkeys after launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from rsesek, round 3. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_SYSTEM_HOTKEY_MAP_H_ 5 #ifndef CONTENT_BROWSER_COCOA_SYSTEM_HOTKEY_MAP_H_
6 #define CHROME_BROWSER_UI_COCOA_SYSTEM_HOTKEY_MAP_H_ 6 #define CONTENT_BROWSER_COCOA_SYSTEM_HOTKEY_MAP_H_
7 7
8 #import <Foundation/Foundation.h> 8 #import <Cocoa/Cocoa.h>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/gtest_prod_util.h"
11 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "content/common/content_export.h"
14
15 namespace content {
12 16
13 struct SystemHotkey; 17 struct SystemHotkey;
14 18
15 // Maintains a listing of all OSX user modifiable hotkeys. e.g. (cmd + `) 19 // Maintains a listing of all OSX system hotkeys. e.g. (cmd + `) These hotkeys
16 class SystemHotkeyMap { 20 // should have higher priority than web content, so NSEvents that correspond to
21 // a system hotkey should not be passed to the renderer.
22 class CONTENT_EXPORT SystemHotkeyMap {
17 public: 23 public:
18 SystemHotkeyMap(); 24 SystemHotkeyMap();
19 ~SystemHotkeyMap(); 25 ~SystemHotkeyMap();
20 26
27 // Converts the plist stored in |data| into an NSDictionary. Returns nil on
28 // error.
29 static NSDictionary* DictionaryFromData(NSData* data);
30
21 // Parses the property list data commonly stored at 31 // Parses the property list data commonly stored at
22 // ~/Library/Preferences/com.apple.symbolichotkeys.plist 32 // ~/Library/Preferences/com.apple.symbolichotkeys.plist
23 // Returns false on encountering an irrecoverable error. 33 // Returns false on encountering an irrecoverable error.
24 // Can be called multiple times. Only the results from the most recent 34 // Can be called multiple times. Only the results from the most recent
25 // invocation are stored. 35 // invocation are stored.
26 bool ParseData(NSData* data); 36 bool ParseDictionary(NSDictionary* dictionary);
37
38 // Whether the event corresponds to a hotkey that has been reserved by the
39 // system.
40 bool IsEventReserved(NSEvent* event) const;
41
42 private:
43 FRIEND_TEST_ALL_PREFIXES(SystemHotkeyMapTest, Parse);
27 44
28 // Whether the hotkey has been reserved by the user. 45 // Whether the hotkey has been reserved by the user.
29 bool IsHotkeyReserved(int key_code, int modifiers); 46 bool IsHotkeyReserved(int key_code, int modifiers) const;
30 47
31 private:
32 // Create at least one record of a hotkey that is reserved by the user. 48 // Create at least one record of a hotkey that is reserved by the user.
33 // Certain system hotkeys automatically reserve multiple key combinations. 49 // Certain system hotkeys automatically reserve multiple key combinations.
34 void ReserveHotkey(int key_code, int modifiers, NSString* system_effect); 50 void ReserveHotkey(int key_code, int modifiers, NSString* system_effect);
35 51
36 // Create a record of a hotkey that is reserved by the user. 52 // Create a record of a hotkey that is reserved by the user.
37 void ReserveHotkey(int key_code, int modifiers); 53 void ReserveHotkey(int key_code, int modifiers);
38 54
39 std::vector<SystemHotkey> system_hotkeys_; 55 std::vector<SystemHotkey> system_hotkeys_;
40 56
41 DISALLOW_COPY_AND_ASSIGN(SystemHotkeyMap); 57 DISALLOW_COPY_AND_ASSIGN(SystemHotkeyMap);
42 }; 58 };
43 59
44 #endif // CHROME_BROWSER_UI_COCOA_SYSTEM_HOTKEY_MAP_H_ 60 } // namespace content
61
62 #endif // CONTENT_BROWSER_COCOA_SYSTEM_HOTKEY_MAP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698