content/public/browser/render_widget_host_view_mac_delegate.h - Issue 370293004: mac: Load the system hotkeys after launch.

Side by Side Diff: content/public/browser/render_widget_host_view_mac_delegate.h

Issue 370293004: mac: Load the system hotkeys after launch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Histograms and dchecks. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/system_hotkey_helper_mac.mm ('K') | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE_H_	5 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE_H_

6 #define CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE_H_	6 #define CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE_H_

7	7

8 #import <Cocoa/Cocoa.h>	8 #import <Cocoa/Cocoa.h>

9	9

10 namespace blink {	10 namespace blink {

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 // These methods control whether a given view is allowed to rubberband in the	53 // These methods control whether a given view is allowed to rubberband in the

54 // given direction. This is inversely related to whether the view is allowed to	54 // given direction. This is inversely related to whether the view is allowed to

55 // 2-finger history swipe in the given direction.	55 // 2-finger history swipe in the given direction.

56 - (BOOL)canRubberbandLeft:(NSView*)view;	56 - (BOOL)canRubberbandLeft:(NSView*)view;

57 - (BOOL)canRubberbandRight:(NSView*)view;	57 - (BOOL)canRubberbandRight:(NSView*)view;

58	58

59 // The browser process received an ACK from the renderer after it processed	59 // The browser process received an ACK from the renderer after it processed

60 // \|event\|.	60 // \|event\|.

61 - (void)rendererHandledWheelEvent:(const blink::WebMouseWheelEvent&)event	61 - (void)rendererHandledWheelEvent:(const blink::WebMouseWheelEvent&)event

62 consumed:(BOOL)consumed;	62 consumed:(BOOL)consumed;

	63

	64 // Whether the event is reserved by OSX.

	65 - (BOOL)eventIsReservedBySystem:(NSEvent*)event;
	Avi (use Gerrit) 2014/07/07 21:57:49 No matter what the embedder is, this feature is ne No matter what the embedder is, this feature is needed, yes? If so, this isn't something that goes here, but this should live entirely in content. erikchen 2014/07/08 01:51:39 I wasn't sure whether this feature should be embed Show quoted text On 2014/07/07 21:57:49, Avi (OOO July 11-27) wrote: > No matter what the embedder is, this feature is needed, yes? If so, this isn't > something that goes here, but this should live entirely in content. I wasn't sure whether this feature should be embedder-agnostic. I've moved all the logic to content/ as per your suggestion. Robert Sesek 2014/07/08 13:40:00 I don't know if this should be embedder-agnostic o Show quoted text On 2014/07/08 01:51:39, erikchen1 wrote: > On 2014/07/07 21:57:49, Avi (OOO July 11-27) wrote: > > No matter what the embedder is, this feature is needed, yes? If so, this isn't > > something that goes here, but this should live entirely in content. > > I wasn't sure whether this feature should be embedder-agnostic. I've moved all > the logic to content/ as per your suggestion. I don't know if this should be embedder-agnostic or not. Is there a scenario where you wouldn't want to obey any system hot keys? Maybe for Chrome Apps? A native app can choose to take over/remap standard hotkeys. I don't know if we want to support this, though. erikchen 2014/07/10 02:07:31 Given that avi has a clear preference, and that my Show quoted text On 2014/07/08 13:40:00, rsesek (OOO July 9-13) wrote: > On 2014/07/08 01:51:39, erikchen1 wrote: > > On 2014/07/07 21:57:49, Avi (OOO July 11-27) wrote: > > > No matter what the embedder is, this feature is needed, yes? If so, this > isn't > > > something that goes here, but this should live entirely in content. > > > > I wasn't sure whether this feature should be embedder-agnostic. I've moved all > > the logic to content/ as per your suggestion. > > I don't know if this should be embedder-agnostic or not. Is there a scenario > where you wouldn't want to obey any system hot keys? Maybe for Chrome Apps? A > native app can choose to take over/remap standard hotkeys. I don't know if we > want to support this, though. Given that avi has a clear preference, and that myself and rsesek seem on the fence, I've kept the logic in content/
63 @end	66 @end

64	67

65 #endif // CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE_H_	68 #endif // CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE_H_

OLD	NEW