Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 370273002: Drop the PLT.StartToFinish.(Proxy / NoProxy) histograms. (Closed)

Created:
6 years, 5 months ago by ppi
Modified:
6 years, 5 months ago
Reviewers:
tonyg, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Drop the PLT.StartToFinish.(Proxy / NoProxy) histograms. These histograms are based on deprecated timing information from DocumentState and have no indicated owner. BUG=384330 R=isherman@chromium.org, tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281739

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M chrome/renderer/page_load_histograms.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ppi
Hi Tony, Ilya - please take a look. These were introduced before the original commit ...
6 years, 5 months ago (2014-07-07 13:08:45 UTC) #1
tonyg
lgtm
6 years, 5 months ago (2014-07-07 14:42:31 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 5 months ago (2014-07-07 23:10:13 UTC) #3
ppi
Thanks!
6 years, 5 months ago (2014-07-08 13:15:13 UTC) #4
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 5 months ago (2014-07-08 13:15:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/370273002/1
6 years, 5 months ago (2014-07-08 13:16:22 UTC) #6
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 5 months ago (2014-07-08 13:48:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/370273002/20001
6 years, 5 months ago (2014-07-08 13:49:48 UTC) #8
ppi
6 years, 5 months ago (2014-07-08 13:59:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r281739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698