Source/core/html/HTMLMediaElement.h - Issue 370203004: Eliminate MediaPlayer abstraction(play/pause, other APIs)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 370203004: Eliminate MediaPlayer abstraction(play/pause, other APIs) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index b797b4c26fbef2ac93ea248ba2f361756884ab8f..4c38e567ac1c79f258829b4636185aa1b473bfd0 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -250,7 +250,7 @@ public:

// of one of them here.

using HTMLElement::executionContext;

- bool hasSingleSecurityOrigin() const { return !m_player || m_player->hasSingleSecurityOrigin(); }

+ bool hasSingleSecurityOrigin() const { return webMediaPlayer() && webMediaPlayer()->hasSingleSecurityOrigin(); }

acolwell GONE FROM CHROMIUM 2014/07/08 00:26:33 Isn't this a behavior change? Shouldn't this be !m

Srirama 2014/07/08 05:06:52 Done.

bool isFullscreen() const;

void enterFullscreen();

« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')