Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 37011: Adds a command line flag, --user-scripts-dir=..., to specify a directory to u... (Closed)

Created:
11 years, 9 months ago by slightlyoff
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adds a command line flag, --user-scripts-dir=..., to specify a directory to use in place of the default user scripts location. This eases development of userscripts since you can simply point the browser at your SCM checkout location instead of needing to try to sync things into your local userscripts directory.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/profile.cc View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
slightlyoff
11 years, 9 months ago (2009-03-06 03:11:14 UTC) #1
Erik does not do reviews
LGTM I think this would be nicer if we could use this as an additional ...
11 years, 9 months ago (2009-03-06 16:50:59 UTC) #2
Evan Martin
http://codereview.chromium.org/37011/diff/3001/2002 File chrome/browser/profile.cc (right): http://codereview.chromium.org/37011/diff/3001/2002#newcode389 Line 389: }else{ spaces around "else" http://codereview.chromium.org/37011/diff/3001/2004 File chrome/common/chrome_switches.cc (right): ...
11 years, 9 months ago (2009-03-06 19:50:09 UTC) #3
slightlyoff
11 years, 9 months ago (2009-03-06 20:11:48 UTC) #4
Thanks, should be fixed in r 3.

On 2009/03/06 19:50:09, Evan Martin wrote:
> http://codereview.chromium.org/37011/diff/3001/2002
> File chrome/browser/profile.cc (right):
> 
> http://codereview.chromium.org/37011/diff/3001/2002#newcode389
> Line 389: }else{
> spaces around "else"
> 
> http://codereview.chromium.org/37011/diff/3001/2004
> File chrome/common/chrome_switches.cc (right):
> 
> http://codereview.chromium.org/37011/diff/3001/2004#newcode380
> Line 380: const wchar_t kUserScriptsDir[]              = L"user-scripts-dir";
> may as well make this align with surrounding lines?

Powered by Google App Engine
This is Rietveld 408576698