Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/views/frame/opaque_browser_frame_view.cc

Issue 37008: Fix another regression. Coordinate calculation in the OpaqueBrowserFrameView:... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/frame/opaque_browser_frame_view.cc
===================================================================
--- chrome/browser/views/frame/opaque_browser_frame_view.cc (revision 10857)
+++ chrome/browser/views/frame/opaque_browser_frame_view.cc (working copy)
@@ -575,8 +575,12 @@
if (l.y() > browser_view_->tabstrip()->bounds().bottom())
return false;
+ // We convert from our parent's coordinates since we assume we fill its bounds
+ // completely. We need to do this since we're not a parent of the tabstrip,
+ // meaning ConvertPointToView would otherwise return something bogus.
gfx::Point tabstrip_point(l);
- View::ConvertPointToView(this, browser_view_->tabstrip(), &tabstrip_point);
+ View::ConvertPointToView(GetParent(), browser_view_->tabstrip(),
+ &tabstrip_point);
return browser_view_->tabstrip()->PointIsWithinWindowCaption(tabstrip_point);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698