Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 37003005: use the supplied matrix instead of the texture w/h div for the bicubic GPU effect (Closed)

Created:
7 years, 2 months ago by humper
Modified:
7 years, 2 months ago
Reviewers:
bsalomon, caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

use the supplied matrix instead of the texture w/h div for the bicubic GPU effect BUG= Committed: http://code.google.com/p/skia/source/detail?r=11921

Patch Set 1 #

Patch Set 2 : add option to clippedbitmap to demonstrate bug this fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M gm/clippedbitmapshaders.cpp View 1 4 chunks +17 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
humper
Fixes issue 1729
7 years, 2 months ago (2013-10-23 14:44:03 UTC) #1
bsalomon
On 2013/10/23 14:44:03, humper wrote: > Fixes issue 1729 Could we have a GM test ...
7 years, 2 months ago (2013-10-23 14:46:07 UTC) #2
humper
On 2013/10/23 14:46:07, bsalomon wrote: > On 2013/10/23 14:44:03, humper wrote: > > Fixes issue ...
7 years, 2 months ago (2013-10-23 15:18:25 UTC) #3
bsalomon
lgtm
7 years, 2 months ago (2013-10-23 15:18:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/37003005/30001
7 years, 2 months ago (2013-10-23 15:43:38 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 16:18:54 UTC) #6
Message was sent while issue was closed.
Change committed as 11921

Powered by Google App Engine
This is Rietveld 408576698