Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1757)

Unified Diff: chrome/browser/ui/views/session_crashed_bubble_view.h

Issue 369933002: Use the correct thread to access g_browser_process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/session_crashed_bubble_view.h
diff --git a/chrome/browser/ui/views/session_crashed_bubble_view.h b/chrome/browser/ui/views/session_crashed_bubble_view.h
index 9ad31ba93ef2e5686e5c1c56fa6c0800831129e9..5b22f46e943788ccd67ce59eeafff5e9a2e68b75 100644
--- a/chrome/browser/ui/views/session_crashed_bubble_view.h
+++ b/chrome/browser/ui/views/session_crashed_bubble_view.h
@@ -51,12 +51,12 @@ class SessionCrashedBubbleView
bool offer_uma_optin);
virtual ~SessionCrashedBubbleView();
- // Creates and shows the session crashed bubble, with |offer_uma_optin|
- // indicating whether the UMA opt-in checkbox should be shown. Called
- // by Show after checking whether the UMA option should be presented and it
- // takes ownership of |browser_observer|.
+ // Creates and shows the session crashed bubble, with |uma_opted_in_already|
+ // indicating whether the user has already opted-in to UMA. It will called by
jwd 2014/07/07 19:57:24 "It will BE called by..."
yao 2014/07/07 20:24:48 Done.
+ // Show after checking the user's current UMA preference. It takes ownership
+ // of |browser_observer|.
static void ShowForReal(scoped_ptr<BrowserRemovalObserver> browser_observer,
- bool offer_uma_optin);
+ bool uma_opted_in_already);
// WidgetDelegateView methods.
virtual views::View* GetInitiallyFocusedView() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698