VaapiVEA: Handle bitrate and frame rate negotiation from webrtc

content/common/gpu/media/vaapi_video_encode_accelerator.cc

Index: content/common/gpu/media/vaapi_video_encode_accelerator.cc
diff --git a/content/common/gpu/media/vaapi_video_encode_accelerator.cc b/content/common/gpu/media/vaapi_video_encode_accelerator.cc
index 6cfdd9d1faa3ec46d02428d206cceb5bcd97d7d0..6cbf0a27aca57e8ae3d1bc531b062f5a4a24235d 100644
--- a/content/common/gpu/media/vaapi_video_encode_accelerator.cc
+++ b/content/common/gpu/media/vaapi_video_encode_accelerator.cc
@@ -745,6 +745,11 @@ void VaapiVideoEncodeAccelerator::RequestEncodingParametersChangeTask(
   DCHECK(encoder_thread_proxy_->BelongsToCurrentThread());
   DCHECK_NE(state_, kUninitialized);
 
+  if (bitrate < 1)
+    bitrate = 1;
+  if (framerate < 1)
+    framerate = 1;

[xhwang, 2014/07/07 16:30:51]

I am not really familiar with this code, so some newbie questions:

1, Why can't webrtc change the default framerate to 1 so that VEAs don't need
this hack anymore. Otherwise, all VEAs need to do the same hack which sounds
bad.

2, What's the unit of |framerate| here, frame per second? If so, is 1 frame per
second a good choice for a default value?

+
   UpdateRates(bitrate, framerate);
 
   UpdateSPS();