Issue 369923004: rlz: Do not take the address of a temporary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 369923004: rlz: Do not take the address of a temporary. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
grt (UTC plus 2)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

rlz: Do not take the address of a temporary. Fixes this warning: taking the address of a temporary object of type 'base::win::RegKey' [-Waddress-of-temporary] (I think the code is fine in this case, but it's a useful warning and we want to be able to build with -Werror.) BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281349

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	rlz/test/rlz_test_helpers.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/369923004/1

6 years, 5 months ago (2014-07-04 00:55:11 UTC) #3

Message was sent while issue was closed.

Change committed as 281349

Expand Messages | Collapse Messages