Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 369923003: NoTransportImageTransportFactory is compiled into only test targets. (Closed)

Created:
6 years, 5 months ago by dshwang
Modified:
6 years, 5 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NoTransportImageTransportFactory is compiled into only test targets. NoTransportImageTransportFactory is used for only unittests, so compile it only for unittests. BUG=N/A Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281802

Patch Set 1 #

Patch Set 2 : Android build fix #

Total comments: 1

Patch Set 3 : fix mac build. merge same condition in gyp. #

Total comments: 2

Patch Set 4 : mvoe no_transport_image_transport_factory.* to test/ #

Patch Set 5 : not miss test/ in git commit #

Total comments: 1

Patch Set 6 : InitializeForUnitTests get scoped_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -143 lines) Patch
M content/browser/compositor/image_transport_factory.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/image_transport_factory.cc View 1 2 3 4 5 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/compositor/no_transport_image_transport_factory.h View 1 2 3 1 chunk +0 lines, -46 lines 0 comments Download
M content/browser/compositor/no_transport_image_transport_factory.cc View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
A + content/browser/compositor/test/no_transport_image_transport_factory.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
A + content/browser/compositor/test/no_transport_image_transport_factory.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 4 5 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 3 chunks +6 lines, -12 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dshwang
Could you review? I also make NoTransportImageTransportFactory compiled into only test targets.
6 years, 5 months ago (2014-07-03 18:36:52 UTC) #1
dshwang
thakis@, could you review content/browser/render_host ?
6 years, 5 months ago (2014-07-03 18:47:19 UTC) #2
Nico
rslgtm if danakj thinks that ownership and whatnot are fine. Not shipping test-only code sounds ...
6 years, 5 months ago (2014-07-03 19:49:04 UTC) #3
dshwang
On 2014/07/03 19:49:04, Nico (away) wrote: > rslgtm if danakj thinks that ownership and whatnot ...
6 years, 5 months ago (2014-07-04 06:45:26 UTC) #4
danakj
https://codereview.chromium.org/369923003/diff/40001/content/browser/compositor/image_transport_factory.h File content/browser/compositor/image_transport_factory.h (right): https://codereview.chromium.org/369923003/diff/40001/content/browser/compositor/image_transport_factory.h#newcode58 content/browser/compositor/image_transport_factory.h:58: static void InitializeForUnitTests(ImageTransportFactory* factory); use scoped_ptr please https://codereview.chromium.org/369923003/diff/40001/content/content_tests.gypi File ...
6 years, 5 months ago (2014-07-07 16:52:27 UTC) #5
dshwang
Thank you for review. On 2014/07/07 16:52:27, danakj wrote: > https://codereview.chromium.org/369923003/diff/40001/content/browser/compositor/image_transport_factory.h > File content/browser/compositor/image_transport_factory.h (right): ...
6 years, 5 months ago (2014-07-08 13:18:25 UTC) #6
danakj
https://codereview.chromium.org/369923003/diff/80001/content/browser/compositor/image_transport_factory.cc File content/browser/compositor/image_transport_factory.cc (right): https://codereview.chromium.org/369923003/diff/80001/content/browser/compositor/image_transport_factory.cc#newcode35 content/browser/compositor/image_transport_factory.cc:35: ImageTransportFactory* factory) { Can you pass the ImageTransportFactory with ...
6 years, 5 months ago (2014-07-08 15:45:53 UTC) #7
dshwang
On 2014/07/08 15:45:53, danakj wrote: > https://codereview.chromium.org/369923003/diff/80001/content/browser/compositor/image_transport_factory.cc > File content/browser/compositor/image_transport_factory.cc (right): > > https://codereview.chromium.org/369923003/diff/80001/content/browser/compositor/image_transport_factory.cc#newcode35 > ...
6 years, 5 months ago (2014-07-08 16:58:21 UTC) #8
danakj
Thanks LGTM
6 years, 5 months ago (2014-07-08 17:01:57 UTC) #9
dshwang
On 2014/07/08 17:01:57, danakj wrote: > Thanks LGTM Thank you for reviewing!
6 years, 5 months ago (2014-07-08 17:02:44 UTC) #10
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 5 months ago (2014-07-08 17:02:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/369923003/100001
6 years, 5 months ago (2014-07-08 17:04:31 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 20:03:26 UTC) #13
Message was sent while issue was closed. 
Change committed as 281802

Powered by Google App Engine
This is Rietveld 408576698