Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 369893008: Move the serial API to extensions/. (Closed)

Created:
6 years, 5 months ago by Sam McNally
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Move the serial API to extensions/. BUG=389016 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282441

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : fix app_shell link #

Patch Set 4 : add missing dependency from usb_service to chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -2244 lines) Patch
M apps/shell/app_shell.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/browser/extensions/api/serial/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/extensions/api/serial/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/extensions/api/serial/serial_api.h View 1 chunk +0 lines, -259 lines 0 comments Download
D chrome/browser/extensions/api/serial/serial_api.cc View 1 chunk +0 lines, -429 lines 0 comments Download
D chrome/browser/extensions/api/serial/serial_apitest.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/extensions/api/serial/serial_connection.h View 1 chunk +0 lines, -216 lines 0 comments Download
D chrome/browser/extensions/api/serial/serial_connection.cc View 1 chunk +0 lines, -381 lines 0 comments Download
D chrome/browser/extensions/api/serial/serial_event_dispatcher.h View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/extensions/api/serial/serial_event_dispatcher.cc View 1 chunk +0 lines, -158 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/api/serial.idl View 1 chunk +0 lines, -323 lines 0 comments Download
M components/usb_service.gypi View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M extensions/browser/api/api_resource_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + extensions/browser/api/serial/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/api/serial/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/api/serial/serial_api.h View 3 chunks +8 lines, -9 lines 0 comments Download
A + extensions/browser/api/serial/serial_api.cc View 17 chunks +70 lines, -47 lines 0 comments Download
A + extensions/browser/api/serial/serial_apitest.cc View 3 chunks +5 lines, -13 lines 0 comments Download
A + extensions/browser/api/serial/serial_connection.h View 4 chunks +15 lines, -17 lines 0 comments Download
A + extensions/browser/api/serial/serial_connection.cc View 10 chunks +66 lines, -56 lines 0 comments Download
A + extensions/browser/api/serial/serial_event_dispatcher.h View 3 chunks +15 lines, -11 lines 0 comments Download
A + extensions/browser/api/serial/serial_event_dispatcher.cc View 5 chunks +29 lines, -29 lines 0 comments Download
M extensions/browser/browser_context_keyed_service_factories.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/common/api/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M extensions/common/api/api.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A + extensions/common/api/serial.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/extensions.gyp View 1 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Sam McNally
kalman@: Please review changes in chrome/{browser,common}/extensions and extensions/ rockot@: Please review the overall change
6 years, 5 months ago (2014-07-08 05:01:58 UTC) #1
not at google - send to devlin
I'm happy for Ken to review this whole thing, but Ken, we need to add ...
6 years, 5 months ago (2014-07-08 15:19:34 UTC) #2
Ken Rockot(use gerrit already)
Pretty straightforward, and also awesome. LGTM! On 2014/07/08 15:19:34, kalman wrote: > I'm happy for ...
6 years, 5 months ago (2014-07-08 19:30:30 UTC) #3
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 5 months ago (2014-07-09 23:44:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/369893008/140001
6 years, 5 months ago (2014-07-09 23:44:51 UTC) #5
Sam McNally
The CQ bit was unchecked by sammc@chromium.org
6 years, 5 months ago (2014-07-10 00:12:57 UTC) #6
Sam McNally
The CQ bit was unchecked by sammc@chromium.org
6 years, 5 months ago (2014-07-10 00:12:57 UTC) #7
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 5 months ago (2014-07-10 00:12:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/369893008/140001
6 years, 5 months ago (2014-07-10 00:14:56 UTC) #9
Sam McNally
The CQ bit was unchecked by sammc@chromium.org
6 years, 5 months ago (2014-07-10 03:26:14 UTC) #10
Sam McNally
+yoz for apps/shell/app_shell.gyp rockot: Can you take a look at components/usb_service.gypi?
6 years, 5 months ago (2014-07-10 07:23:20 UTC) #11
Yoyo Zhou
app_shell.gyp lgtm
6 years, 5 months ago (2014-07-10 19:05:41 UTC) #12
Ken Rockot(use gerrit already)
A bit confused about how this was missing, but lgtm
6 years, 5 months ago (2014-07-10 19:22:42 UTC) #13
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 5 months ago (2014-07-10 21:59:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/369893008/180001
6 years, 5 months ago (2014-07-10 22:00:06 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 22:46:28 UTC) #16
Message was sent while issue was closed. 
Change committed as 282441

Powered by Google App Engine
This is Rietveld 408576698