chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc - Issue 369893005: Implement new design for expanded public session pod design

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

Issue 369893005: Implement new design for expanded public session pod design (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments. Made sure PS "enter" button cannot be tabbed to when PS pod is not expanded. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screens/user_selection_screen.cc ('k') | chrome/browser/resources/chromeos/login/login.html » ('j') | chrome/browser/resources/login/user_pod_row.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

diff --git a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

index b6dfdbd9776ebcae049809d07843d7005de19017..04216eb5a54589e89be3e10f18d88294c69bba76 100644

--- a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

+++ b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

@@ -51,6 +51,11 @@ screenlock::AuthType FromLockHandlerAuthType(

case ScreenlockBridge::LockHandler::ONLINE_SIGN_IN:

// Apps should treat forced online sign in same as system password.

return screenlock::AUTH_TYPE_OFFLINEPASSWORD;

+ case ScreenlockBridge::LockHandler::EXPAND_THEN_USER_CLICK:

+ // This type is used for public sessions, which do not support screen

+ // locking.

+ NOTREACHED();

+ return screenlock::AUTH_TYPE_NONE;

}

NOTREACHED();

return screenlock::AUTH_TYPE_OFFLINEPASSWORD;