Implement new design for expanded public session pod design

Implement new design for expanded public session pod design

This CL implements the new design for expanded public session pods from
crbug.com/214904#c40. The basic pod is added now. The advanced pod will
be added in a follow-up CL.

The new design requires a different animation when the pod is expanding:
An expanded pane slides out to the side and part of the main pane
disappears. To facilitate this new animation, the CL refactors the HTML
and CSS implementing user pods to be more modular with several panes
that can overlap each other. This will also make it easier to implement
the new standard pod design in crbug.com/361375.

BUG=214904, 241790
TEST=Manual, for all pod types, including desktop

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282618

[bartfab (slow), 2014-07-03 17:59:15]

Hi all,

This is my WIP CL. It should apply cleanly to ToT.

The markup for all normally-sized pods is done and should match the current one
(except for a few pixel-perfection fixes). The markup for expanded public
session pods is missing. I will be working on that on Monday.

- Bartosz

[dzhioev (left Google), 2014-07-07 10:35:43]

This CL breaks positioning of screen going next to GAIA-screen ("Syncing your
settings..."). See screenshot http://goo.gl/Lq9t7A

https://codereview.chromium.org/369893005/diff/1/chrome/browser/resources/log...
File chrome/browser/resources/login/user_pod_row.css (right):

https://codereview.chromium.org/369893005/diff/1/chrome/browser/resources/log...
chrome/browser/resources/login/user_pod_row.css:426: /* Public session pods have
the attribute auth-type='offlinePassword' set,
Can't we set right type for public pods?

[bartfab (slow), 2014-07-07 18:16:03]

Thanks for catching the misplaced screen. This is fixed now.

I am still working on the expanded public session pods. ETA is tomorrow.

https://codereview.chromium.org/369893005/diff/1/chrome/browser/resources/log...
File chrome/browser/resources/login/user_pod_row.css (right):

https://codereview.chromium.org/369893005/diff/1/chrome/browser/resources/log...
chrome/browser/resources/login/user_pod_row.css:426: /* Public session pods have
the attribute auth-type='offlinePassword' set,
On 2014/07/07 10:35:42, dzhioev wrote:
> Can't we set right type for public pods?

Done.

[bartfab (slow), 2014-07-08 16:54:47]

Hi Pavel,

Could you take a look at this CL?

Hi Benjamin,

Could you do an owner review of the following file:
chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

Hi Nikita,

Could you do an owner review of the following file:
chrome/browser/resources/user_manager/user_manager.css

Hi Drew,

Could you do an owner review of the following file:
chrome/browser/signin/screenlock_bridge.h

[not at google - send to devlin, 2014-07-08 16:55:59]

extensions lgtm

[Andrew T Wilson (Slow), 2014-07-09 13:28:25]

signin lgtm

[dzhioev (left Google), 2014-07-09 13:49:46]

Here is what I found so far. I can't guarantee that everything else is right,
because it's very hard to review CSS.

https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/login/user_pod_row.js (left):

https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
chrome/browser/resources/login/user_pod_row.js:500:
this.signinButtonElement.hidden = !this.isAuthTypeOnlineSignIn;
You probably need to change some of SAMLPPolicyTest-s, because they expect that
'.signin-button' has 'hidden' attribute set.

https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/login/user_pod_row.js (right):

https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
chrome/browser/resources/login/user_pod_row.js:457:
this.classList.toggle('signed-in', this.user_.signedIn);
You forgot to remove 'hidden' attribute from 'signed-in-indicator' in user pod
template, so the indicator is always hidden.

[bartfab (slow), 2014-07-09 19:08:11]

https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/login/user_pod_row.js (left):

https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
chrome/browser/resources/login/user_pod_row.js:500:
this.signinButtonElement.hidden = !this.isAuthTypeOnlineSignIn;
On 2014/07/09 13:49:46, dzhioev wrote:
> You probably need to change some of SAMLPPolicyTest-s, because they expect
that
> '.signin-button' has 'hidden' attribute set.

Done.

https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/login/user_pod_row.js (right):

https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
chrome/browser/resources/login/user_pod_row.js:457:
this.classList.toggle('signed-in', this.user_.signedIn);
On 2014/07/09 13:49:46, dzhioev wrote:
> You forgot to remove 'hidden' attribute from 'signed-in-indicator' in user pod
> template, so the indicator is always hidden.

Done.

[dzhioev (left Google), 2014-07-10 13:15:26]

On 2014/07/09 19:08:11, bartfab wrote:
>
https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
> File chrome/browser/resources/login/user_pod_row.js (left):
> 
>
https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
> chrome/browser/resources/login/user_pod_row.js:500:
> this.signinButtonElement.hidden = !this.isAuthTypeOnlineSignIn;
> On 2014/07/09 13:49:46, dzhioev wrote:
> > You probably need to change some of SAMLPPolicyTest-s, because they expect
> that
> > '.signin-button' has 'hidden' attribute set.
> 
> Done.
> 
>
https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
> File chrome/browser/resources/login/user_pod_row.js (right):
> 
>
https://codereview.chromium.org/369893005/diff/60001/chrome/browser/resources...
> chrome/browser/resources/login/user_pod_row.js:457:
> this.classList.toggle('signed-in', this.user_.signedIn);
> On 2014/07/09 13:49:46, dzhioev wrote:
> > You forgot to remove 'hidden' attribute from 'signed-in-indicator' in user
pod
> > template, so the indicator is always hidden.
> 
> Done.

LGTM.

[Nikita (slow), 2014-07-10 15:39:41]

+Monica

[Nikita (slow), 2014-07-10 15:56:23]

lgtm

I assume you've also checked RTL case for cros/desktop.

https://codereview.chromium.org/369893005/diff/80001/chrome/browser/resources...
File chrome/browser/resources/login/user_pod_row.js (left):

https://codereview.chromium.org/369893005/diff/80001/chrome/browser/resources...
chrome/browser/resources/login/user_pod_row.js:200: if
(this.actionBoxRemoveUserWarningButtonElement) {
nit: this guard is not needed?

[bartfab (slow), 2014-07-10 15:59:24]

https://codereview.chromium.org/369893005/diff/80001/chrome/browser/resources...
File chrome/browser/resources/login/user_pod_row.js (left):

https://codereview.chromium.org/369893005/diff/80001/chrome/browser/resources...
chrome/browser/resources/login/user_pod_row.js:200: if
(this.actionBoxRemoveUserWarningButtonElement) {
On 2014/07/10 15:56:22, Nikita Kostylev wrote:
> nit: this guard is not needed?

|actionBoxRemoveUserWarningButtonElement| is the div with class
|remove-warning-button|. This div is part of the main pod template, so every pod
will have it.

[bartfab (slow), 2014-07-10 16:28:17]

I had verified that everything works correctly in RTL on CrOS. I verified that
it works correctly on desktop as well now. For future reference, to get RTL on
desktop, you do:

env LANG=ar.UTF-8 LANGUAGE=ar.UTF-8 out/Release/chrome

[bartfab (slow), 2014-07-10 16:28:49]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-07-10 16:31:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/369893005/80001

[commit-bot: I haz the power, 2014-07-10 19:41:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-07-10 20:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 20:53:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[bartfab (slow), 2014-07-11 10:17:21]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-07-11 10:18:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/369893005/100001

[commit-bot: I haz the power, 2014-07-11 12:18:23]

Change committed as 282618