Hydrogenized KeyedLoadGeneric stub: exhaustively search dictionary properties.

Hydrogenized KeyedLoadGeneric stub: exhaustively search dictionary properties.

And call the runtime instead of stub-failing when the property isn't found.

R=danno@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22239

[Jakob Kummerow, 2014-07-03 16:23:26]

PTAL.

This builds on the "while(true) {}" LoopBuilder support you've reviewed earlier.

If you have any suggestions for how to reformat or refactor this code to make it
more readable, I'm all ears. On the other hand, we'll probably have to
significantly change all this anyway when we add prototype chain walking, so
spending too much effort on formatting right now probably isn't worthwhile.

[danno, 2014-07-07 08:10:26]

lgtm

https://codereview.chromium.org/369893004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/369893004/diff/1/src/hydrogen.cc#newcode1691
src/hydrogen.cc:1691: probe_loop.BeginBody(2);  // Drop entry, count from last
environment to
This makes me gag, but I guess there is no other way.

[Jakob Kummerow, 2014-07-07 11:40:44]

Thanks, landing.

https://codereview.chromium.org/369893004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/369893004/diff/1/src/hydrogen.cc#newcode1691
src/hydrogen.cc:1691: probe_loop.BeginBody(2);  // Drop entry, count from last
environment to
On 2014/07/07 08:10:26, danno wrote:
> This makes me gag, but I guess there is no other way.

I don't like it either, but don't see a way around it. The other BeginBody()
implementation uses a similar hack (popping one element off each of the three
environments involved), it just manages to hide it from callers, because the
count is always 1 in its case.

[Jakob Kummerow, 2014-07-07 11:43:08]

Committed patchset #1 manually as r22239 (presubmit successful).