Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 369853002: DevTools: Rename TargetAwareObject into SDKObject (Closed)

Created:
6 years, 5 months ago by sergeyv
Modified:
6 years, 5 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Rename TargetAwareObject into SDKObject TBR=vsevik BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177473

Patch Set 1 #

Patch Set 2 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -120 lines) Patch
M Source/devtools/front_end/audits/AuditController.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/ApplicationCacheModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/BreakpointManager.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/CPUProfilerModel.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/ConsoleModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMStorage.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/Database.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 10 chunks +12 lines, -12 lines 0 comments Download
M Source/devtools/front_end/sdk/FileSystemModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/HeapProfilerModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/IndexedDBModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/LayerTreeModel.js View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/LiveEditSupport.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkLog.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkManager.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkRequest.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/Resource.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceTreeModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/RuntimeModel.js View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/Script.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 chunk +2 lines, -21 lines 0 comments Download
M Source/devtools/front_end/sdk/TimelineManager.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingModel.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-03 08:54:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/369853002/1
6 years, 5 months ago (2014-07-03 08:54:41 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 10:09:26 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/devtools/front_end/sdk/CPUProfilerModel.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-03 10:09:27 UTC) #4
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-03 11:22:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/369853002/20001
6 years, 5 months ago (2014-07-03 11:23:07 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-03 12:29:36 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 13:01:38 UTC) #8
Message was sent while issue was closed.
Change committed as 177473

Powered by Google App Engine
This is Rietveld 408576698