Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 369833003: Fix orderfile buildbot by excluding SaturatedArithmetic.h from instrumentation. (Closed)

Created:
6 years, 5 months ago by azarchs
Modified:
6 years, 5 months ago
Reviewers:
pasko
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix orderfile buildbot by excluding SaturatedArithmetic.h from instrumentation. The methods in that header are inline assembly which require inlining, so instrumentation doesn't work with them, and also doesn't matter. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
azarchs
6 years, 5 months ago (2014-07-04 17:43:51 UTC) #1
pasko
lgtm
6 years, 5 months ago (2014-07-04 17:45:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/azarchs@chromium.org/369833003/1
6 years, 5 months ago (2014-07-04 17:46:39 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-04 19:57:34 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 20:07:40 UTC) #5
Message was sent while issue was closed.
Change committed as 281435

Powered by Google App Engine
This is Rietveld 408576698