Tests added for user-listing on sign-in screen.

Tests added for user-listing on sign-in screen.

BUG=353936
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281292

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283417

[dzhioev (left Google), 2014-07-03 11:53:21]

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc (right):

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:18: const
size_t kMaxUsers = 18; // same as in user_selection_screen.cc
Either share this constant, or add comment in user_selection_screen.cc asking to
keep these constants in sync.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:53: const
std::string user_email(kUsersPublic[i]);
|user_email| is not needed, pass |kUsersPublic[i]| directly to
|AddPublicAccountUser|.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:88: 
Add check that list returned by GetUsers has at least (kMaxUsers + 2) users.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:89: size_t
list_length = kMaxUsers;
|list_length| is not needed.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:91:
EXPECT_EQ(kOwner, users_to_send[kMaxUsers-1]->email());
users_to_send.back()->email()

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:113:
EXPECT_EQ("a0@gmail.com", users_to_send[0]->email());
users_to_send.front()

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:120:
EXPECT_EQ("public0@gmail.com", users_to_send[0]->email());
users_to_send.front()

[merkulova, 2014-07-03 13:46:06]

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc (right):

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:18: const
size_t kMaxUsers = 18; // same as in user_selection_screen.cc
On 2014/07/03 11:53:21, dzhioev wrote:
> Either share this constant, or add comment in user_selection_screen.cc asking
to
> keep these constants in sync. 

Done.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:53: const
std::string user_email(kUsersPublic[i]);
On 2014/07/03 11:53:20, dzhioev wrote:
> |user_email| is not needed, pass |kUsersPublic[i]| directly to
> |AddPublicAccountUser|.

Done.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:88: 
On 2014/07/03 11:53:20, dzhioev wrote:
> Add check that list returned by GetUsers has at least (kMaxUsers + 2) users.

Done.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:89: size_t
list_length = kMaxUsers;
On 2014/07/03 11:53:20, dzhioev wrote:
> |list_length| is not needed.

Done.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:91:
EXPECT_EQ(kOwner, users_to_send[kMaxUsers-1]->email());
On 2014/07/03 11:53:20, dzhioev wrote:
> users_to_send.back()->email()

Done.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:113:
EXPECT_EQ("a0@gmail.com", users_to_send[0]->email());
On 2014/07/03 11:53:20, dzhioev wrote:
> users_to_send.front()

Done.

https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:120:
EXPECT_EQ("public0@gmail.com", users_to_send[0]->email());
On 2014/07/03 11:53:21, dzhioev wrote:
> users_to_send.front()

Done.

[dzhioev (left Google), 2014-07-03 13:50:59]

On 2014/07/03 13:46:06, merkulova wrote:
>
https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
> File chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc
(right):
> 
>
https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
> chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:18: const
> size_t kMaxUsers = 18; // same as in user_selection_screen.cc
> On 2014/07/03 11:53:21, dzhioev wrote:
> > Either share this constant, or add comment in user_selection_screen.cc
asking
> to
> > keep these constants in sync. 
> 
> Done.
> 
>
https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
> chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:53: const
> std::string user_email(kUsersPublic[i]);
> On 2014/07/03 11:53:20, dzhioev wrote:
> > |user_email| is not needed, pass |kUsersPublic[i]| directly to
> > |AddPublicAccountUser|.
> 
> Done.
> 
>
https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
> chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:88: 
> On 2014/07/03 11:53:20, dzhioev wrote:
> > Add check that list returned by GetUsers has at least (kMaxUsers + 2) users.
> 
> Done.
> 
>
https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
> chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:89: size_t
> list_length = kMaxUsers;
> On 2014/07/03 11:53:20, dzhioev wrote:
> > |list_length| is not needed.
> 
> Done.
> 
>
https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
> chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:91:
> EXPECT_EQ(kOwner, users_to_send[kMaxUsers-1]->email());
> On 2014/07/03 11:53:20, dzhioev wrote:
> > users_to_send.back()->email()
> 
> Done.
> 
>
https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
> chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:113:
> mailto:EXPECT_EQ("a0@gmail.com", users_to_send[0]->email());
> On 2014/07/03 11:53:20, dzhioev wrote:
> > users_to_send.front()
> 
> Done.
> 
>
https://codereview.chromium.org/369833002/diff/1/chrome/browser/ui/webui/chro...
> chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:120:
> mailto:EXPECT_EQ("public0@gmail.com", users_to_send[0]->email());
> On 2014/07/03 11:53:21, dzhioev wrote:
> > users_to_send.front()
> 
> Done.
LGTM

[merkulova, 2014-07-03 14:23:06]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-07-03 14:23:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/369833002/20001

[commit-bot: I haz the power, 2014-07-03 16:11:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-03 17:37:43]

Change committed as 281292

[merkulova, 2014-07-16 09:37:18]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-07-16 09:38:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/369833002/40001

[commit-bot: I haz the power, 2014-07-16 13:01:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-16 17:52:31]

Change committed as 283417