Issue 369813003: Enable 32/64-bit gyp switch on Android

Issue 369813003: Enable 32/64-bit gyp switch on Android (Closed)

Created:
6 years, 5 months ago by qiankun

Modified:
6 years, 5 months ago

Reviewers:
djsollen, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Enable 32/64-bit gyp switch on Android Select 32/64-bit Skia build according skia_arch_width on Android. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d312a04ffacb8e86a2d2eb37985b154ab4e9d3c6

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
	M	gyp/common_conditions.gypi	View		2 chunks	+20 lines, -20 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

qiankun

PTAL. I intend to enable 64-bit Skia on Android IA. This is the first step.

6 years, 5 months ago (2014-07-03 11:15:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/369813003/1

6 years, 5 months ago (2014-07-07 16:31:34 UTC) #4

qiankun

On 2014/07/07 12:54:26, mtklein wrote: > lgtm How can I update NDK in Skia? I ...

6 years, 5 months ago (2014-07-07 16:33:13 UTC) #5

commit-bot: I haz the power

Change committed as d312a04ffacb8e86a2d2eb37985b154ab4e9d3c6

6 years, 5 months ago (2014-07-07 16:47:28 UTC) #6

djsollen

On 2014/07/07 16:33:13, qiankun wrote: > On 2014/07/07 12:54:26, mtklein wrote: > > lgtm > ...

6 years, 5 months ago (2014-07-07 19:14:39 UTC) #7

qiankun

6 years, 5 months ago (2014-07-08 01:12:01 UTC) #8

Message was sent while issue was closed.

On 2014/07/07 19:14:39, djsollen wrote:
> On 2014/07/07 16:33:13, qiankun wrote:
> > On 2014/07/07 12:54:26, mtklein wrote:
> > > lgtm
> > 
> > How can I update NDK in Skia? I make a standalone NDK from NDK experimental
(
> > https://chromium.googlesource.com/android_tools/+/master/ndk_experimental ).
> > Current, NDK for Skia is downloaded from google storage.
> 
> There is currently not an official NDK release that has the correct
toolchains. 
> We can use an experimental NDK until the official release is available to
enable
> 64-bit support and upload those.  Can you file a Skia bug about this?

I have filed a bug: http://code.google.com/p/skia/issues/detail?id=2660

Expand Messages | Collapse Messages