Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: Source/core/animation/AnimationPlayerTest.cpp

Issue 369793003: Make the web-animations engine use the passed in blink::WebFrameTime values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixing remaining usages of -1 in the code. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/AnimationClockTest.cpp ('k') | Source/core/animation/AnimationStackTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimationPlayerTest.cpp
diff --git a/Source/core/animation/AnimationPlayerTest.cpp b/Source/core/animation/AnimationPlayerTest.cpp
index 37660e69b825abd5b90229633d49dce2fa0d0acd..c2349b8b614d564504a133b0010cb2f2cadf2768 100644
--- a/Source/core/animation/AnimationPlayerTest.cpp
+++ b/Source/core/animation/AnimationPlayerTest.cpp
@@ -55,7 +55,8 @@ protected:
void setUpWithoutStartingTimeline()
{
document = Document::create();
- document->animationClock().resetTimeForTesting();
+ document->animationClock().clearTimeForTesting();
+ document->animationClock().updateTime(AnimationClock::createTimeForTesting(0, 0));
timeline = AnimationTimeline::create(document.get());
player = timeline->createAnimationPlayer(0);
player->setStartTimeInternal(0);
@@ -77,7 +78,7 @@ protected:
bool updateTimeline(double time)
{
- document->animationClock().updateTime(time);
+ document->animationClock().updateTime(AnimationClock::createTimeForTesting(time, time + 1));
// The timeline does not know about our player, so we have to explicitly call update().
return player->update(TimingUpdateOnDemand);
}
@@ -119,7 +120,7 @@ TEST_F(AnimationAnimationPlayerTest, CurrentTimeDoesNotSetOutdated)
// FIXME: We should split updateTimeline into a version that doesn't update
// the player and one that does, as most of the tests don't require update()
// to be called.
- document->animationClock().updateTime(10);
+ document->animationClock().updateTime(AnimationClock::createTimeForTesting(10, 11));
EXPECT_EQ(10, player->currentTimeInternal());
EXPECT_FALSE(player->outdated());
}
« no previous file with comments | « Source/core/animation/AnimationClockTest.cpp ('k') | Source/core/animation/AnimationStackTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698