Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 36973002: Clean up toHTMLFooElement() using DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clean up toHTMLFooElement() using DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION Some HTML elements don't use type cast macro. This cl cleans up those HTML elements. To use DEFINE_NODE_CASTS_WITH_FUNCTION, this cl need to add isHTMLFooElement() additionally. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160415

Patch Set 1 #

Total comments: 13

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -66 lines) Patch
M Source/core/html/HTMLAreaElement.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLLabelElement.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLMeterElement.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLProgressElement.h View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLTableElement.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.h View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLVideoElement.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/shadow/HTMLContentElement.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/shadow/HTMLShadowElement.h View 1 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 2 months ago (2013-10-24 01:06:41 UTC) #1
tkent
https://chromiumcodereview.appspot.com/36973002/diff/1/Source/core/html/HTMLAreaElement.h File Source/core/html/HTMLAreaElement.h (right): https://chromiumcodereview.appspot.com/36973002/diff/1/Source/core/html/HTMLAreaElement.h#newcode71 Source/core/html/HTMLAreaElement.h:71: inline bool isHTMLAreaElement(const Node& node) I don't think we ...
7 years, 2 months ago (2013-10-24 01:22:31 UTC) #2
gyuyoung-inactive
https://chromiumcodereview.appspot.com/36973002/diff/1/Source/core/html/HTMLAreaElement.h File Source/core/html/HTMLAreaElement.h (right): https://chromiumcodereview.appspot.com/36973002/diff/1/Source/core/html/HTMLAreaElement.h#newcode71 Source/core/html/HTMLAreaElement.h:71: inline bool isHTMLAreaElement(const Node& node) On 2013/10/24 01:22:32, tkent ...
7 years, 2 months ago (2013-10-24 01:53:12 UTC) #3
tkent
https://chromiumcodereview.appspot.com/36973002/diff/20001/Source/core/html/HTMLProgressElement.h File Source/core/html/HTMLProgressElement.h (right): https://chromiumcodereview.appspot.com/36973002/diff/20001/Source/core/html/HTMLProgressElement.h#newcode77 Source/core/html/HTMLProgressElement.h:77: inline bool isHTMLProgressElement(Node& node) This looks unnecessary. https://chromiumcodereview.appspot.com/36973002/diff/20001/Source/core/html/HTMLTableRowElement.h File ...
7 years, 2 months ago (2013-10-24 02:02:19 UTC) #4
gyuyoung-inactive
https://chromiumcodereview.appspot.com/36973002/diff/20001/Source/core/html/HTMLProgressElement.h File Source/core/html/HTMLProgressElement.h (right): https://chromiumcodereview.appspot.com/36973002/diff/20001/Source/core/html/HTMLProgressElement.h#newcode77 Source/core/html/HTMLProgressElement.h:77: inline bool isHTMLProgressElement(Node& node) On 2013/10/24 02:02:19, tkent wrote: ...
7 years, 2 months ago (2013-10-24 02:08:19 UTC) #5
tkent
lgtm
7 years, 2 months ago (2013-10-24 02:13:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/36973002/80001
7 years, 2 months ago (2013-10-24 02:13:31 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=9491
7 years, 2 months ago (2013-10-24 03:21:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/36973002/80001
7 years, 2 months ago (2013-10-24 03:25:51 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-24 04:15:14 UTC) #10
Message was sent while issue was closed. 
Change committed as 160415

Powered by Google App Engine
This is Rietveld 408576698