Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 369713002: Remove destructors from ScriptWrappable objects (part 1) (Closed)

Created:
6 years, 5 months ago by haraken
Modified:
6 years, 5 months ago
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, abarth-chromium, dglazkov+blink, blink-reviews-bindings_chromium.org, darktears, apavlov+blink_chromium.org, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Remove destructors from ScriptWrappable objects (part 1) BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177471

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -45 lines) Patch
M Source/bindings/core/v8/custom/V8CustomXPathNSResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/clipboard/DataTransferItem.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/clipboard/DataTransferItem.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/clipboard/DataTransferItemList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/clipboard/DataTransferItemList.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/css/CSSMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PagePopupController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/MemoryInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/DOMParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/NativeXPathNSResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/NativeXPathNSResolver.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/xml/XMLSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathEvaluator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathExpression.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathExpression.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/xml/XPathNSResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathNSResolver.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/xml/XPathResult.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathResult.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
haraken
PTAL
6 years, 5 months ago (2014-07-03 01:34:39 UTC) #1
sof
lgtm, nice. https://codereview.chromium.org/369713002/diff/1/Source/core/clipboard/DataTransferItem.h File Source/core/clipboard/DataTransferItem.h (right): https://codereview.chromium.org/369713002/diff/1/Source/core/clipboard/DataTransferItem.h#newcode49 Source/core/clipboard/DataTransferItem.h:49: class DataTransferItem FINAL : public RefCountedWillBeGarbageCollectedFinalized<DataTransferItem>, public ...
6 years, 5 months ago (2014-07-03 06:05:18 UTC) #2
haraken
Thanks for review! https://codereview.chromium.org/369713002/diff/1/Source/core/clipboard/DataTransferItem.h File Source/core/clipboard/DataTransferItem.h (right): https://codereview.chromium.org/369713002/diff/1/Source/core/clipboard/DataTransferItem.h#newcode49 Source/core/clipboard/DataTransferItem.h:49: class DataTransferItem FINAL : public RefCountedWillBeGarbageCollectedFinalized<DataTransferItem>, ...
6 years, 5 months ago (2014-07-03 11:17:44 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 5 months ago (2014-07-03 11:17:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/369713002/20001
6 years, 5 months ago (2014-07-03 11:19:06 UTC) #5
zerny-chromium
Great that we can start getting rid of these :-) lgtm
6 years, 5 months ago (2014-07-03 11:20:16 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-03 12:23:54 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 12:54:18 UTC) #8
Message was sent while issue was closed. 
Change committed as 177471

Powered by Google App Engine
This is Rietveld 408576698