| Index: base/prefs/pref_member.cc
|
| diff --git a/base/prefs/pref_member.cc b/base/prefs/pref_member.cc
|
| index eb708394979964615eec8db0c9222ae0de220632..229e5f2e550157f15dadadc7564afe72ffb59c22 100644
|
| --- a/base/prefs/pref_member.cc
|
| +++ b/base/prefs/pref_member.cc
|
| @@ -8,10 +8,11 @@
|
| #include "base/callback_helpers.h"
|
| #include "base/location.h"
|
| #include "base/prefs/pref_service.h"
|
| +#include "base/sequenced_task_runner.h"
|
| +#include "base/single_thread_task_runner.h"
|
| +#include "base/thread_task_runner_handle.h"
|
| #include "base/value_conversions.h"
|
|
|
| -using base::MessageLoopProxy;
|
| -
|
| namespace subtle {
|
|
|
| PrefMemberBase::PrefMemberBase()
|
| @@ -52,13 +53,13 @@ void PrefMemberBase::Destroy() {
|
| }
|
| }
|
|
|
| -void PrefMemberBase::MoveToThread(
|
| - const scoped_refptr<MessageLoopProxy>& message_loop) {
|
| +void PrefMemberBase::MoveToTaskRunner(
|
| + const scoped_refptr<base::SequencedTaskRunner>& task_runner) {
|
| VerifyValuePrefName();
|
| // Load the value from preferences if it hasn't been loaded so far.
|
| if (!internal())
|
| UpdateValueFromPref(base::Closure());
|
| - internal()->MoveToThread(message_loop);
|
| + internal()->MoveToTaskRunner(task_runner);
|
| }
|
|
|
| void PrefMemberBase::OnPreferenceChanged(PrefService* service,
|
| @@ -93,15 +94,17 @@ void PrefMemberBase::InvokeUnnamedCallback(const base::Closure& callback,
|
| }
|
|
|
| PrefMemberBase::Internal::Internal()
|
| - : thread_loop_(MessageLoopProxy::current()),
|
| - is_managed_(false),
|
| + : is_managed_(false),
|
| is_user_modifiable_(false) {
|
| + // In unit tests, there may not be a message loop.
|
| + if (base::ThreadTaskRunnerHandle::IsSet())
|
| + task_runner_ = base::ThreadTaskRunnerHandle::Get();
|
| }
|
| PrefMemberBase::Internal::~Internal() { }
|
|
|
| bool PrefMemberBase::Internal::IsOnCorrectThread() const {
|
| // In unit tests, there may not be a message loop.
|
| - return thread_loop_.get() == NULL || thread_loop_->BelongsToCurrentThread();
|
| + return task_runner_.get() == NULL || task_runner_->RunsTasksOnCurrentThread();
|
| }
|
|
|
| void PrefMemberBase::Internal::UpdateValue(
|
| @@ -117,19 +120,22 @@ void PrefMemberBase::Internal::UpdateValue(
|
| is_managed_ = is_managed;
|
| is_user_modifiable_ = is_user_modifiable;
|
| } else {
|
| - bool may_run = thread_loop_->PostTask(
|
| + bool may_run = task_runner_->PostTask(
|
| FROM_HERE,
|
| - base::Bind(&PrefMemberBase::Internal::UpdateValue, this,
|
| - value.release(), is_managed, is_user_modifiable,
|
| + base::Bind(&PrefMemberBase::Internal::UpdateValue,
|
| + this,
|
| + value.release(),
|
| + is_managed,
|
| + is_user_modifiable,
|
| closure_runner.Release()));
|
| DCHECK(may_run);
|
| }
|
| }
|
|
|
| -void PrefMemberBase::Internal::MoveToThread(
|
| - const scoped_refptr<MessageLoopProxy>& message_loop) {
|
| +void PrefMemberBase::Internal::MoveToTaskRunner(
|
| + const scoped_refptr<base::SequencedTaskRunner>& task_runner) {
|
| CheckOnCorrectThread();
|
| - thread_loop_ = message_loop;
|
| + task_runner_ = task_runner;
|
| }
|
|
|
| bool PrefMemberVectorStringUpdate(const base::Value& value,
|
|
|