Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: base/test/thread_test_helper.h

Issue 369703003: Reduce usage of MessageLoopProxy in base/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Explicit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TEST_THREAD_TEST_HELPER_H_ 5 #ifndef BASE_TEST_THREAD_TEST_HELPER_H_
6 #define BASE_TEST_THREAD_TEST_HELPER_H_ 6 #define BASE_TEST_THREAD_TEST_HELPER_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/message_loop/message_loop_proxy.h"
11 #include "base/synchronization/waitable_event.h" 10 #include "base/synchronization/waitable_event.h"
12 11
13 namespace base { 12 namespace base {
14 13
14 class SequencedTaskRunner;
15
15 // Helper class that executes code on a given thread while blocking on the 16 // Helper class that executes code on a given thread while blocking on the
16 // invoking thread. To use, derive from this class and overwrite RunTest. An 17 // invoking thread. To use, derive from this class and overwrite RunTest. An
17 // alternative use of this class is to use it directly. It will then block 18 // alternative use of this class is to use it directly. It will then block
18 // until all pending tasks on a given thread have been executed. 19 // until all pending tasks on a given thread have been executed.
19 class ThreadTestHelper : public RefCountedThreadSafe<ThreadTestHelper> { 20 class ThreadTestHelper : public RefCountedThreadSafe<ThreadTestHelper> {
20 public: 21 public:
21 explicit ThreadTestHelper(MessageLoopProxy* target_thread); 22 explicit ThreadTestHelper(
23 const scoped_refptr<SequencedTaskRunner>& target_task_runner);
22 24
23 // True if RunTest() was successfully executed on the target thread. 25 // True if RunTest() was successfully executed on the target thread.
24 bool Run() WARN_UNUSED_RESULT; 26 bool Run() WARN_UNUSED_RESULT;
25 27
26 virtual void RunTest(); 28 virtual void RunTest();
27 29
28 protected: 30 protected:
29 friend class RefCountedThreadSafe<ThreadTestHelper>; 31 friend class RefCountedThreadSafe<ThreadTestHelper>;
30 32
31 virtual ~ThreadTestHelper(); 33 virtual ~ThreadTestHelper();
32 34
33 // Use this method to store the result of RunTest(). 35 // Use this method to store the result of RunTest().
34 void set_test_result(bool test_result) { test_result_ = test_result; } 36 void set_test_result(bool test_result) { test_result_ = test_result; }
35 37
36 private: 38 private:
37 void RunInThread(); 39 void RunInThread();
38 40
39 bool test_result_; 41 bool test_result_;
40 scoped_refptr<MessageLoopProxy> target_thread_; 42 scoped_refptr<SequencedTaskRunner> target_task_runner_;
41 WaitableEvent done_event_; 43 WaitableEvent done_event_;
42 44
43 DISALLOW_COPY_AND_ASSIGN(ThreadTestHelper); 45 DISALLOW_COPY_AND_ASSIGN(ThreadTestHelper);
44 }; 46 };
45 47
46 } // namespace base 48 } // namespace base
47 49
48 #endif // BASE_TEST_THREAD_TEST_HELPER_H_ 50 #endif // BASE_TEST_THREAD_TEST_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698