Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: content/public/browser/ssl_host_state_decisions.h

Issue 369703002: Remember user decisions on invalid certificates behind a flag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed several bot compile errors Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/ssl_host_state_decisions.h
diff --git a/content/public/browser/ssl_host_state_decisions.h b/content/public/browser/ssl_host_state_decisions.h
new file mode 100644
index 0000000000000000000000000000000000000000..a03dc176ed1cb1119313376d0d352d05164b7fd5
--- /dev/null
+++ b/content/public/browser/ssl_host_state_decisions.h
@@ -0,0 +1,40 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_SSL_HOST_STATE_DECISIONS_H_
+#define CONTENT_BROWSER_SSL_HOST_STATE_DECISIONS_H_
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "content/common/content_export.h"
+#include "net/cert/x509_certificate.h"
+
+class GURL;
+
+namespace content {
+
+// SSLHostStateDecisions must be implemented by the embedder, to provide the
+// storage strategy (if any) for certificate decisions.
jam 2014/07/31 22:01:08 this sounds like it's required by the embedder, wh
jww 2014/07/31 23:53:10 Done.
+class CONTENT_EXPORT SSLHostStateDecisions {
jam 2014/07/31 22:01:08 for consistency, this should be something like SSL
jww 2014/07/31 23:53:10 I've changed it to SSLHostStateDecisionsDelegate s
jww 2014/08/01 00:21:35 Okay, so I think I understand a bit better what yo
+ public:
+ virtual void DenyCert(const GURL& url,
jam 2014/07/31 22:01:08 nit: please comment all these methods
jww 2014/07/31 23:53:10 Done.
+ net::X509Certificate* cert,
+ net::CertStatus error) = 0;
+ virtual void AllowCert(const GURL& url,
+ net::X509Certificate* cert,
+ net::CertStatus error) = 0;
+ virtual void Clear() = 0;
+ virtual net::CertPolicy::Judgment QueryPolicy(const GURL& url,
+ net::X509Certificate* cert,
+ net::CertStatus error) = 0;
+ virtual void RevokeAllowAndDenyPreferences(const GURL& url) = 0;
+ virtual bool HasAllowedOrDeniedCert(const GURL& url) = 0;
+
+ protected:
+ virtual ~SSLHostStateDecisions() {}
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_SSL_HOST_STATE_DECISIONS_H_

Powered by Google App Engine
This is Rietveld 408576698