Remember user decisions on invalid certificates behind a flag

content/public/browser/browser_context.h

Index: content/public/browser/browser_context.h
diff --git a/content/public/browser/browser_context.h b/content/public/browser/browser_context.h
index 1c09777f42b2bd6690fa39a40dbd56b033b79911..1cb1c7845c8690012aa55478f703613b90925c13 100644
--- a/content/public/browser/browser_context.h
+++ b/content/public/browser/browser_context.h
@@ -40,6 +40,7 @@ class PushMessagingService;
 class ResourceContext;
 class SiteInstance;
 class StoragePartition;
+class SSLHostStateDecisions;
 
 // This class holds the context needed for a browsing session.
 // It lives on the UI thread. All these methods must only be called on the UI
@@ -149,6 +150,10 @@ class CONTENT_EXPORT BrowserContext : public base::SupportsUserData {
   // responsible for ensuring that it outlives RenderProcessHost. It's valid to
   // return NULL.
   virtual PushMessagingService* GetPushMessagingService() = 0;
+
+  // Returns the SSL host state decisions for this context. It is not valid to
+  // return NULL, except for testing contexts.

[Torne, 2014/07/31 09:40:16]

You've written here that it's not valid to return NULL except for testing, but
the aw_browser_context implementation you added returns NULL. Are we going to
have to implement a real version of this function in android_webview, or is it
okay like this despite the comment? What is the actual effect of returning NULL
here?

[jww, 2014/07/31 18:08:57]

Great catch! Indeed, this was a problem, and I've just uploaded a fix. We
*should* allow NULL SSLHostStates, and that should imply a default "don't
remember anything" strategy, which is the current behavior of Android Web View
and Content Shell. In the Web View case, felt@ is toying with how we might
actually do interstitials, but that's a longer term plan, and definitely not
something to address in this CL.

+  virtual SSLHostStateDecisions* GetSSLHostStateDecisions() = 0;
 };
 
 }  // namespace content