Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: chrome/browser/about_flags.cc

Issue 369703002: Remember user decisions on invalid certificates behind a flag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes from felt plus new incognito browser tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 4b52c35735b8fba39a3712434270ecc50cb1d388..5ced9355f9b76cd150629b8226bf47c299f693ab 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -491,6 +491,27 @@ const Experiment::Choice kEnableSettingsWindowChoices[] = {
::switches::kDisableSettingsWindow, "" },
};
+// Note that the value is specified in seconds (where 0 is equivalent to
+// disabled).
+const Experiment::Choice kRememberCertificateErrorDecisionsChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+ switches::kRememberCertErrorDecisions,
+ "0" },
+ { IDS_REMEMBER_CERTIFICATE_ERROR_DECISION_CHOICE_ONE_DAY,
+ switches::kRememberCertErrorDecisions,
+ "86400" },
+ { IDS_REMEMBER_CERTIFICATE_ERROR_DECISION_CHOICE_THREE_DAYS,
+ switches::kRememberCertErrorDecisions,
+ "259200" },
+ { IDS_REMEMBER_CERTIFICATE_ERROR_DECISION_CHOICE_ONE_WEEK,
+ switches::kRememberCertErrorDecisions,
+ "604800" },
+ { IDS_REMEMBER_CERTIFICATE_ERROR_DECISION_CHOICE_ONE_MONTH,
+ switches::kRememberCertErrorDecisions,
+ "2592000" },
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -1975,6 +1996,13 @@ const Experiment kExperiments[] = {
kOsDesktop,
SINGLE_VALUE_TYPE(extensions::switches::kEnableEmbeddedExtensionOptions)
},
+ {
+ "remember-cert-error-decisions",
+ IDS_FLAGS_REMEMBER_CERTIFICATE_ERROR_DECISIONS_NAME,
+ IDS_FLAGS_REMEMBER_CERTIFICATE_ERROR_DECISIONS_DESCRIPTION,
+ kOsAll,
+ MULTI_VALUE_TYPE(kRememberCertificateErrorDecisionsChoices)
+ },
};
const Experiment* experiments = kExperiments;

Powered by Google App Engine
This is Rietveld 408576698