ui/app_list/views/search_result_list_view.cc - Issue 369693004: Make app list search result mixer more resilient to reordering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/search_result_list_view.cc

Issue 369693004: Make app list search result mixer more resilient to reordering. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rework algorithm, rebase onto https://codereview.chromium.org/372843003/ Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/app_list/views/search_result_list_view.cc

diff --git a/ui/app_list/views/search_result_list_view.cc b/ui/app_list/views/search_result_list_view.cc

index c844ef2359b9149d69bfea23939a377d7e2e81f1..6f2b17622c04f417f91d36ee88e221c531fa0b6e 100644

--- a/ui/app_list/views/search_result_list_view.cc

+++ b/ui/app_list/views/search_result_list_view.cc

@@ -261,7 +261,7 @@ void SearchResultListView::ListItemMoved(size_t index, size_t target_index) {

}

void SearchResultListView::ListItemsChanged(size_t start, size_t count) {

- ScheduleUpdate();

+ NOTREACHED();

Matt Giuca 2014/07/09 01:30:55 Did this become unreachable, or was it always? I d

calamity 2014/07/09 03:03:49 It's unreachable because NotifyItemsChanged is no

}

void SearchResultListView::SearchResultActivated(SearchResultView* view,