chrome/browser/ui/app_list/search/mixer.h - Issue 369693004: Make app list search result mixer more resilient to reordering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/mixer.h

Issue 369693004: Make app list search result mixer more resilient to reordering. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rework algorithm, rebase onto https://codereview.chromium.org/372843003/ Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/search/mixer.h

diff --git a/chrome/browser/ui/app_list/search/mixer.h b/chrome/browser/ui/app_list/search/mixer.h

index b7e16415f45c6856b5a9ef028f6ef786e72d4c3e..c555145fc79f2a5ac2c45f7b88ea86a4b8ee7ebb 100644

--- a/chrome/browser/ui/app_list/search/mixer.h

+++ b/chrome/browser/ui/app_list/search/mixer.h

@@ -67,8 +67,9 @@ class Mixer {

class Group;

typedef ScopedVector<Group> Groups;

- // Publishes the given |results| to |ui_results|. Reuse existing ones to avoid

- // flickering.

+ // Publishes the given |new_results| to |ui_results|, deleting any existing

+ // results that are not in |new_results|. Results that already exist in

+ // |ui_results| are reused to avoid flickering caused by icon reload.

static void Publish(const SortedResults& results,

AppListModel::SearchResults* ui_results);