Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: content/browser/service_worker/service_worker_unregister_job.cc

Issue 369693002: ServiceWorker: Unregistering active version should mark it redundant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_job_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_unregister_job.cc
diff --git a/content/browser/service_worker/service_worker_unregister_job.cc b/content/browser/service_worker/service_worker_unregister_job.cc
index 48f51ee12c00a1dc67ba9749e78a75cec8ac639c..b4505e6ec4f248087c6484213da2c697d74784e8 100644
--- a/content/browser/service_worker/service_worker_unregister_job.cc
+++ b/content/browser/service_worker/service_worker_unregister_job.cc
@@ -71,6 +71,11 @@ void ServiceWorkerUnregisterJob::DeleteRegistration(
// TODO(nhiroki): When we've implemented the installing version, terminate and
// set it to redundant here as per spec.
+ if (registration->active_version()) {
+ registration->active_version()->SetStatus(
+ ServiceWorkerVersion::REDUNDANT);
+ }
+
if (registration->waiting_version()) {
registration->waiting_version()->SetStatus(
ServiceWorkerVersion::REDUNDANT);
« no previous file with comments | « content/browser/service_worker/service_worker_job_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698