Issue 369683004: remove unneeded flags for android

Issue 369683004: remove unneeded flags for android (Closed)

Created:
6 years, 5 months ago by reed1

Modified:
6 years, 5 months ago

Reviewers:
scroggo

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
M	gyp/common.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gyp/common_conditions.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gyp/skia_for_android_framework_defines.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

scroggo

On 2014/07/07 20:07:29, reed1 wrote: Can you also remove SK_CAN_USE_FLOAT from gyp/common.gypi and kNative_8888_SkColorType from ...

6 years, 5 months ago (2014-07-07 20:21:24 UTC) #2

reed1

On 2014/07/07 20:21:24, scroggo wrote: > On 2014/07/07 20:07:29, reed1 wrote: > > Can you ...

6 years, 5 months ago (2014-07-07 20:22:44 UTC) #3

reed1

On 2014/07/07 20:21:24, scroggo wrote: > On 2014/07/07 20:07:29, reed1 wrote: > > Can you ...

6 years, 5 months ago (2014-07-07 20:25:49 UTC) #4

scroggo

On 2014/07/07 20:25:49, reed1 wrote: > On 2014/07/07 20:21:24, scroggo wrote: > > On 2014/07/07 ...

6 years, 5 months ago (2014-07-07 20:29:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/369683004/20001

6 years, 5 months ago (2014-07-07 20:32:50 UTC) #7

commit-bot: I haz the power

6 years, 5 months ago (2014-07-07 20:49:02 UTC) #8

Message was sent while issue was closed.

Change committed as 58f1e925fdfc48779a4ac5db734889fc8c39afd2