Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4486)

Unified Diff: chrome/browser/history/history_backend.h

Issue 369673009: Change AndroidHistoryProviderService to use CancelableTaskTracker (2/6) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.2
Patch Set: clang-format Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index 9e24f06c8226ca75f856db89e23731e07486e305..94a3f7d3d9f204def8255f38321aeaa01f905a64 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -284,8 +284,7 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
void InsertHistoryAndBookmark(scoped_refptr<InsertRequest> request,
const HistoryAndBookmarkRow& row);
- void QueryHistoryAndBookmarks(
- scoped_refptr<QueryRequest> request,
+ history::AndroidStatement* QueryHistoryAndBookmarks(
const std::vector<HistoryAndBookmarkRow::ColumnID>& projections,
const std::string& selection,
const std::vector<base::string16>& selection_args,
@@ -329,11 +328,11 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
const std::string& selection,
const std::vector<base::string16> selection_args);
- void QuerySearchTerms(scoped_refptr<QueryRequest> request,
- const std::vector<SearchRow::ColumnID>& projections,
- const std::string& selection,
- const std::vector<base::string16>& selection_args,
- const std::string& sort_order);
+ history::AndroidStatement* QuerySearchTerms(
Miguel Garcia 2014/07/07 09:51:57 nit: can you document what the methods you are tou
sdefresne 2014/07/16 08:07:24 Done.
+ const std::vector<SearchRow::ColumnID>& projections,
+ const std::string& selection,
+ const std::vector<base::string16>& selection_args,
+ const std::string& sort_order);
#endif // defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698