Issue 369673008: [Cleanup] No need for extra boolean variable in FrameSelection::caretBlinkTimerFired

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 369673008: [Cleanup] No need for extra boolean variable in FrameSelection::caretBlinkTimerFired (Closed)

Created:
6 years, 5 months ago by Sunil Ratnu

Modified:
6 years, 5 months ago

Reviewers:
tkent, Yuta Kitamura, yosin_UTC9

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

[Cleanup] No need for extra boolean variable in FrameSelection::caretBlinkTimerFired. The extra boolean variable is not needed. Removing it. R=tkent@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177503

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	Source/core/editing/FrameSelection.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

tkent

lgtm The CL description should contain class/function name. e.g. [Cleanup] No ned for extra boolean ...

6 years, 5 months ago (2014-07-04 01:28:13 UTC) #2

yosin_UTC9

LGTM Thanks for cleanup! Please don't forget update description before committing.

6 years, 5 months ago (2014-07-04 01:40:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/369673008/1

6 years, 5 months ago (2014-07-04 01:59:27 UTC) #5

Message was sent while issue was closed.

Change committed as 177503