Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 369673007: Hydrogenized KeyedLoadGeneric stub: Fix BuildDecodeField (Closed)

Created:
6 years, 5 months ago by Jakob Kummerow
Modified:
6 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Hydrogenized KeyedLoadGeneric stub: Fix BuildDecodeField R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/hydrogen.h View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL. For reference, the C++ implementation is: static T decode(U value) { return static_cast<T>((value & ...
6 years, 5 months ago (2014-07-03 08:46:25 UTC) #1
Yang
On 2014/07/03 08:46:25, Jakob wrote: > PTAL. > > For reference, the C++ implementation is: ...
6 years, 5 months ago (2014-07-03 08:47:34 UTC) #2
Jakob Kummerow
6 years, 5 months ago (2014-07-03 08:58:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698