Issue 369673002: Use BUILD_NATIVE_TEST instead of BUILD_EXECUTABLE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 369673002: Use BUILD_NATIVE_TEST instead of BUILD_EXECUTABLE. (Closed)

Created:
6 years, 5 months ago by scroggo

Modified:
6 years, 5 months ago

Reviewers:
hal.canary, djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Use BUILD_NATIVE_TEST instead of BUILD_EXECUTABLE. This will generate makefiles for our tools (bench, tests, gm, dm) using the line "include $(BUILD_NATIVE_TEST)". This has been recommended by the Android team, as it builds both 32 bit and 64 bit versions of the test. Do not use LOCAL_MODULE_PATH, which is deprecated (see https://docs.google.com/a/google.com/document/d/1uLAuY7_KYGx1TSzJ9SXkyevT8qNpra2ZoIBkmCoq8VM/edit# ). Corresponds to ag/498302 , which makes this change just for bench. Committed: https://skia.googlesource.com/skia/+/f50a79366f49fdc5ea726c74642ad6a706f1fe64

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -21 lines)			Patch
M	platform_tools/android/bin/gyp_to_android.py	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	platform_tools/android/gyp_gen/tool_makefile_writer.py	View	1	3 chunks	+5 lines, -16 lines	0 comments	Download
M	platform_tools/android/tests/expectations/tool/Android.mk	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	platform_tools/android/tests/makefile_writer_tests.py	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/369673002/20001

6 years, 5 months ago (2014-07-08 18:02:27 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-08 18:21:01 UTC) #5

Message was sent while issue was closed.

Change committed as f50a79366f49fdc5ea726c74642ad6a706f1fe64