Lay groudwork to Closure compile JavaScript

ui/webui/resources/js/i18n_template.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * NOTE: The use of this file is deprecated. Use i18n_template2.js instead.
  *
  * @fileoverview This is a simple template engine inspired by JsTemplates
  * optimized for i18n.
  *
  * It currently supports two handlers:
  *
  *   * i18n-content which sets the textContent of the element
  *
  *     <span i18n-content="myContent"></span>
  *     i18nTemplate.process(element, {'myContent': 'Content'});
  *
  *   * i18n-values is a list of attribute-value or property-value pairs.
  *     Properties are prefixed with a '.' and can contain nested properties.
  *
  *     <span i18n-values="title:myTitle;.style.fontSize:fontSize"></span>
  *     i18nTemplate.process(element, {
  *       'myTitle': 'Title',
  *       'fontSize': '13px'
  *     });
  */
 
+/** @typedef {function(!Element, string, Object)} */
+var Handler;
+
 var i18nTemplate = (function() {
   /**
    * This provides the handlers for the templating engine. The key is used as
    * the attribute name and the value is the function that gets called for every
    * single node that has this attribute.
-   * @type {Object}
+   * @type {Object.<Handler>}
    */
   var handlers = {
     /**
      * This handler sets the textContent of the element.
      */
     'i18n-content': function(element, attributeValue, obj) {
       element.textContent = obj[attributeValue];
     },
 
     /**
@@ skipping 28 matching lines @@
             if (propName.charAt(0) == '.') {
               var path = propName.slice(1).split('.');
               var object = element;
               while (object && path.length > 1) {
                 object = object[path.shift()];
               }
               if (object) {
                 object[path] = value;
                 // In case we set innerHTML (ignoring others) we need to
                 // recursively check the content
-                if (path == 'innerHTML') {
+                if (path == 'innerHTML')
                   process(element, obj);
-                }
               }
             } else {
               element.setAttribute(propName, value);
             }
           } else {
             console.warn('i18n-values: Missing value for "' + propExpr + '"');
           }
         }
       }
     }
   };
 
   var attributeNames = [];
   for (var key in handlers) {
     attributeNames.push(key);
   }
   var selector = '[' + attributeNames.join('],[') + ']';
 
   /**
    * Processes a DOM tree with the {@code obj} map.
+   * @param {Node} node A node to process.
+   * @param {Object} obj Values to process |node| with.
    */
   function process(node, obj) {
     var elements = node.querySelectorAll(selector);

[arv (Not doing code reviews), 2014/07/16 18:33:03]

Node does not have querySelectorAll. Do you want to change it to {ParentNode}?

[Dan Beam, 2014/07/19 02:28:40]

MDN says it's on Element...
https://developer.mozilla.org/en-US/docs/Web/API/Element.querySelectorAll

As long as it compiles I don't particularly care.  I don't think Node has
.classList either but it worked in the new CL:
https://chromiumcodereview.appspot.com/405743002/

[arv (Not doing code reviews), 2014/07/21 18:25:31]

MDN is wrong. Shocking!

classList is part of Element
http://dom.spec.whatwg.org/#element

querySelectorAll is part of ParentNode
http://dom.spec.whatwg.org/#parentnode
That is how google3 js type annotations got into a mess. It was almost
impossible to fix these things because the amount of invalid type annotations
out there was astonishing.

     for (var element, i = 0; element = elements[i]; i++) {
       for (var j = 0; j < attributeNames.length; j++) {
         var name = attributeNames[j];
         var att = element.getAttribute(name);
-        if (att != null) {
+        if (att != null)
           handlers[name](element, att, obj);
-        }
       }
     }
   }
 
   return {
     process: process
   };
 })();