Lay groudwork to Closure compile JavaScript

ui/webui/resources/js/chromeos/ui_account_tweaks.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview This file contains methods that allow to tweak
  * internal page UI based on the status of current user (owner/user/guest).
  * It is assumed that required data is passed via i18n strings
  * (using loadTimeData dictionary) that are filled with call to
  * AddAccountUITweaksLocalizedValues in ui_account_tweaks.cc.
@@ skipping 107 matching lines @@
     UIAccountTweaks.disableElementForSessionType_(element, sessionType);
 
     // Walk the tree, searching each ELEMENT node.
     var walker = document.createTreeWalker(element,
                                            NodeFilter.SHOW_ELEMENT,
                                            null,
                                            false);
 
     var node = walker.nextNode();
     while (node) {
-      UIAccountTweaks.disableElementForSessionType_(node, sessionType);
+      UIAccountTweaks.disableElementForGuest_(
+          /** @type {Element} */(node), sessionType);

[arv (Not doing code reviews), 2014/07/16 18:33:02]

Sad :'(

[apavlov, 2014/07/16 18:56:14]

On a side note, {Element} means "Element or null", so you should use {!Element}
and such, whenever it makes sense.

[Dan Beam, 2014/07/19 02:28:39]

yep, thanks.

I just converted most of the code to use Node instead to make arv@ less :'(.

see https://chromiumcodereview.appspot.com/405743002/ for the split CL that does
this.

       node = walker.nextNode();
     }
   };
 
   /**
    * Disables single element for given session type.
    * Adds *sessionType*-disabled css class, adds disabled attribute for
    * appropriate elements (input/select/button), and removes href attribute from
    * <a> element.
    *
-   * @private
    * @param {Element} element Element that should be disabled.
    * @param {string} sessionType account session Type specificator.
+   * @private
    */
   UIAccountTweaks.disableElementForSessionType_ = function(element,
                                                            sessionType) {
     element.classList.add(sessionType + '-disabled');
     if (element.nodeName == 'INPUT' ||
         element.nodeName == 'SELECT' ||
-        element.nodeName == 'BUTTON')
+        element.nodeName == 'BUTTON') {
       element.disabled = true;
-    if (element.nodeName == 'A') {
+    } else if (element.nodeName == 'A') {
       element.onclick = function() {
         return false;
       };
     }
   };
 
   // Export
   return {
     UIAccountTweaks: UIAccountTweaks
   };
 
 });