Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 369633003: Remove ScriptWrappable's destructor in Oilpan builds. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove ScriptWrappable's destructor in Oilpan builds. r177389 (http://crrev.com/362963005) made ScriptWrappable's destructor empty in Oilpan builds. Take the next step and do not define it at all. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177436

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/bindings/core/v8/ScriptWrappable.h View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look. Assuming we don't want give the empty dtor of ScriptWrappable special ...
6 years, 5 months ago (2014-07-02 20:47:23 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-02 23:17:14 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 5 months ago (2014-07-02 23:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/369633003/1
6 years, 5 months ago (2014-07-02 23:17:44 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 01:06:42 UTC) #5
Message was sent while issue was closed.
Change committed as 177436

Powered by Google App Engine
This is Rietveld 408576698